[clang-c] Don't deprecate CXRemapping as well as its users #149975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm#149079 deprecated CXRemapping and all its methods, however MSVC warns when a deprecated method is using a deprecated variable (and breaks our Werror builds) - best way to avoid this is to only deprecate the methods directly.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Simon Pilgrim (RKSimon) Changes#149079 deprecated CXRemapping and all its methods, however MSVC warns when a deprecated method is using a deprecated variable (and breaks our Werror builds) - best way to avoid this is to only deprecate the methods directly. Full diff: https://github.com/llvm/llvm-project/pull/149975.diff 1 Files Affected:
diff --git a/clang/include/clang-c/Index.h b/clang/include/clang-c/Index.h
index b929585205aee..10b70b4f53eac 100644
--- a/clang/include/clang-c/Index.h
+++ b/clang/include/clang-c/Index.h
@@ -6953,7 +6953,6 @@ clang_getCursorUnaryOperatorKind(CXCursor cursor);
* @}
*/
-CINDEX_DEPRECATED
typedef void *CXRemapping;
CINDEX_DEPRECATED CINDEX_LINKAGE CXRemapping clang_getRemappings(const char *);
|
AaronBallman
approved these changes
Jul 22, 2025
Collaborator
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
Thanks for this! One minor suggestion, but otherwise this LGTM
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
llvm#149079 deprecated CXRemapping and all its methods, however MSVC warns when a deprecated method is using a deprecated variable (and breaks our Werror builds) - best way to avoid this is to only deprecate the methods directly.
sivadeilra
pushed a commit
to sivadeilra/llvm-project
that referenced
this pull request
Nov 13, 2025
llvm#149079 deprecated CXRemapping and all its methods, however MSVC warns when a deprecated method is using a deprecated variable (and breaks our Werror builds) - best way to avoid this is to only deprecate the methods directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149079 deprecated CXRemapping and all its methods, however MSVC warns when a deprecated method is using a deprecated variable (and breaks our Werror builds) - best way to avoid this is to only deprecate the methods directly.