Skip to content

[mlir][Arith] Prevent IR modification for non-matching pattern #150103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

[mlir][Arith] Prevent IR modification for non-matching pattern #150103

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
864392b
[mlir][Arith] Prevent IR modification for non-matching pattern
krzysz00 Jul 22, 2025
7c1b38b
Remove a can't-happen match failure
krzysz00 Jul 22, 2025
e7b5116
Revert "Remove a can't-happen match failure"
krzysz00 Jul 22, 2025
93646f2
Add explanatory comment for guard, fix misc. whitespace issues
krzysz00 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions mlir/lib/Dialect/Arith/Transforms/ExpandOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,10 +518,10 @@ struct F4E2M1TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
Type i32Ty = cloneToShapedType(operandTy, b.getI32Type());
Type f32Ty = cloneToShapedType(operandTy, b.getF32Type());

if (!isa<Float32Type>(operandETy))
operand = b.create<arith::ExtFOp>(f32Ty, operand);
if (!isa<Float4E2M1FNType>(resultETy))
return rewriter.notifyMatchFailure(op, "not a trunc of F4E2M1FN");
if (!isa<Float32Type>(operandETy))
operand = b.create<arith::ExtFOp>(f32Ty, operand);

Value c0x1 = createConst(loc, i4Ty, 1, rewriter);
Value c0x3 = createConst(loc, i4Ty, 3, rewriter);
Expand Down Expand Up @@ -657,6 +657,7 @@ struct ScalingExtFOpConverter : public OpRewritePattern<arith::ScalingExtFOp> {
scaleOperand = b.create<arith::TruncFOp>(scaleTy, scaleOperand, nullptr,
op.getFastmathAttr());
}
// Catch scale types like f8E5M2.
if (!llvm::isa<Float8E8M0FNUType>(scaleETy)) {
return rewriter.notifyMatchFailure(
op, "scaling_extf is using scales of type which can not be converted "
Expand Down Expand Up @@ -777,7 +778,7 @@ struct ArithExpandOpsPass
if (includeBf16)
legalTypes &= !(inETy.isF32() && outETy.isBF16());
if (includeF8E8M0)
legalTypes &= !(llvm::isa<Float8E8M0FNUType>(outETy));
legalTypes &= !(llvm::isa<Float8E8M0FNUType>(outETy));
if (includeF4E2M1)
legalTypes &= !llvm::isa<Float4E2M1FNType>(outETy);
return legalTypes;
Expand Down Expand Up @@ -832,7 +833,7 @@ void mlir::arith::populateArithExpandOpsPatterns(RewritePatternSet &patterns) {
MaximumMinimumFOpConverter<MaximumFOp, arith::CmpFPredicate::UGT>,
MaximumMinimumFOpConverter<MinimumFOp, arith::CmpFPredicate::ULT>,
MaxNumMinNumFOpConverter<MaxNumFOp, arith::CmpFPredicate::UGT>,
MaxNumMinNumFOpConverter<MinNumFOp, arith::CmpFPredicate::ULT>
MaxNumMinNumFOpConverter<MinNumFOp, arith::CmpFPredicate::ULT>
>(patterns.getContext());
// clang-format on
}