Skip to content

[lldb] support ieee_single and ieee_double gdbtypes for registers #150268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

[lldb] support ieee_single and ieee_double gdbtypes for registers #150268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4783,7 +4783,8 @@ bool ParseRegisters(
} else if (gdb_type == "data_ptr" || gdb_type == "code_ptr") {
reg_info.format = eFormatAddressInfo;
reg_info.encoding = eEncodingUint;
} else if (gdb_type == "float") {
} else if (gdb_type == "float" || gdb_type == "ieee_single" ||
gdb_type == "ieee_double") {
reg_info.format = eFormatFloat;
reg_info.encoding = eEncodingIEEE754;
} else if (gdb_type == "aarch64v" ||
Expand Down
11 changes: 11 additions & 0 deletions lldb/test/API/functionalities/gdb_remote_client/TestGDBServerTargetXML.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,9 @@ class MyResponder(MockGDBServerResponder):
"0102030405060708" # t4
"0102030405060708" # t5
"0102030405060708" # t6
"6162636465666768" # pc
Copy link
Collaborator

@DavidSpickett DavidSpickett Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that we just didn't provide data for the PC before? Surprised that the test worked at all.

Copy link
Contributor Author

@satyajanga satyajanga Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test also was't validating for pc before. the stop reply packet (from haltReason func) has the PC

"0000C03F" # ft0
"e07a6147a8a40940" # ft1
)

def qXferRead(self, obj, annex, offset, length):
Expand Down Expand Up @@ -737,6 +740,10 @@ def qXferRead(self, obj, annex, offset, length):
<reg name="t6" bitsize="64" type="int"/>
<reg name="pc" bitsize="64" type="code_ptr"/>
</feature>
<feature name='org.gnu.gdb.riscv.fpu'>
<reg name='ft0' bitsize='32' type='ieee_single'/>
<reg name='ft1' bitsize='64' type='ieee_double'/>
</feature>
</target>""",
False,
)
Expand Down Expand Up @@ -799,6 +806,10 @@ def haltReason(self):
self.match("register read x29", ["t4 = 0x0807060504030201"])
self.match("register read x30", ["t5 = 0x0807060504030201"])
self.match("register read x31", ["t6 = 0x0807060504030201"])
self.match("register read pc", ["pc = 0x6867666564636261"])
# test FPU registers
self.match("register read ft0", ["ft0 = 1.5"])
self.match("register read ft1", ["ft1 = 3.2053990913985757"])

@skipIfXmlSupportMissing
@skipIfRemote
Expand Down
Loading