Skip to content

[Flang][OpenMP][Docs] Update target-related support in Flang docs, NFC #150443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skatrak merged 2 commits into from
Jul 29, 2025
Merged

[Flang][OpenMP][Docs] Update target-related support in Flang docs, NFC #150443

skatrak merged 2 commits into from
Jul 29, 2025

Conversation

@skatrak
Copy link
Member

@skatrak skatrak commented Jul 24, 2025 •
edited
Loading

Update docs to state that reduction is supported on OpenMP loop and teams standalone and compound constructs.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Jul 24, 2025
@skatrak skatrak changed the title Update target-related support in Flang docs [Flang][OpenMP][Docs] Update target-related support in Flang docs, NFC Jul 24, 2025
ergawy
ergawy approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@ergawy ergawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loop-related changes LGTM! Thanks for the updates Sergio!

kiranchandramohan
kiranchandramohan approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sergio, for the update. Can you clarify in the summary (reduction is supported?), what is the change here?

I saw the following issue in our tracker. But is probably a separate issue.
#148709

LGTM.

@skatrak
Copy link
Member Author

skatrak commented Jul 28, 2025

Thanks, Sergio, for the update. Can you clarify in the summary (reduction is supported?), what is the change here?

I saw the following issue in our tracker. But is probably a separate issue. #148709

LGTM.

Thanks Kiran, just updated the PR description. The issue does look like some edge case, but reductions on teams are generally expected to work.

@skatrak skatrak merged commit 1598062 into main Jul 29, 2025
10 checks passed
@skatrak skatrak deleted the users/skatrak/flang-docs branch July 29, 2025 15:50
@tblah
Copy link
Contributor

tblah commented Jul 31, 2025

I wonder if this should be backported to LLVM 21 so that the documentation remains correct there too?

@tblah tblah added this to the LLVM 21.x Release milestone Jul 31, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Jul 31, 2025
@tblah
Copy link
Contributor

tblah commented Jul 31, 2025

/cherry-pick 1598062

@llvmbot
Copy link
Member

llvmbot commented Jul 31, 2025

/pull-request #151493

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Jul 31, 2025
tru pushed a commit to llvmbot/llvm-project that referenced this pull request Aug 5, 2025
@skatrak @tru
[Flang][OpenMP][Docs] Update target-related support in Flang docs, NFC (
b38f357 
llvm#150443)

Update docs to state that reduction is supported on OpenMP `loop` and
`teams` standalone and compound constructs.

(cherry picked from commit 1598062)
@dwblaikie dwblaikie mentioned this pull request Sep 16, 2025
Merged
@jhuber6 jhuber6 mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ergawy ergawy ergawy approved these changes

@kiranchandramohan kiranchandramohan kiranchandramohan approved these changes

@dpalermo dpalermo dpalermo approved these changes

@jsjodin jsjodin Awaiting requested review from jsjodin

@tblah tblah Awaiting requested review from tblah

Assignees

No one assigned

Labels

flang Flang issues not falling into any other category

Projects

LLVM Release Status
Status: Done

Milestone

LLVM 21.x Release

Development

Successfully merging this pull request may close these issues.

7 participants

@skatrak @tblah @llvmbot @ergawy @kiranchandramohan @dpalermo