Skip to content

[clang-doc] Precommit param comment test changes #150469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[clang-doc] Precommit param comment test changes #150469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 90 additions & 2 deletions clang-tools-extra/test/clang-doc/basic-project.mustache.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,24 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC-NOT: </div>
Copy link
Contributor

@ilovepi ilovepi Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this check break when it matches the at the end?

Copy link
Member Author

@evelez7 evelez7 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these tests pass on my machine.

HTML-CALC-NOT: <h3>Parameters</h3>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>a</b> <div>
HTML-CALC-NOT: <p> First integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>b</b> <div>
HTML-CALC-NOT: <p> Second integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
Expand Down Expand Up @@ -299,7 +316,24 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <h3>Parameters</h3>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>a</b> <div>
HTML-CALC-NOT: <p> First integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>b</b> <div>
HTML-CALC-NOT: <p> Second integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
Expand All @@ -319,6 +353,23 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <h3>Parameters</h3>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>a</b> <div>
HTML-CALC-NOT: <p> First integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>b</b> <div>
HTML-CALC-NOT: <p> Second integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
Expand All @@ -339,6 +390,23 @@ HTML-CALC: <p></p>
HTML-CALC: </div>
HTML-CALC: <div>
HTML-CALC: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <h3>Parameters</h3>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>a</b> <div>
HTML-CALC-NOT: <p> First integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <b>b</b> <div>
HTML-CALC-NOT: <p> Second integer.</p>
HTML-CALC-NOT: </div>
HTML-CALC-NOT: <div>
HTML-CALC-NOT: <p></p>
HTML-CALC-NOT: </div>
HTML-CALC: </div>
HTML-CALC: </div>
HTML-CALC: </div>
Expand Down Expand Up @@ -438,6 +506,20 @@ HTML-RECTANGLE: <p></p>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: <div>
HTML-RECTANGLE: <p></p>
HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE-NOT: <h3>Parameters</h3>
HTML-RECTANGLE-NOT: <div>
HTML-RECTANGLE-NOT: <b>width</b> <div>
HTML-RECTANGLE-NOT: <p> Width of the rectangle.</p>
HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE-NOT: <div>
HTML-RECTANGLE-NOT: <p></p>
HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE-NOT: <div>
HTML-RECTANGLE-NOT: <b>height</b> <div>
HTML-RECTANGLE-NOT: <p> Height of the rectangle.</p>
HTML-RECTANGLE-NOT: </div>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: </div>
HTML-RECTANGLE: </div>
Expand Down Expand Up @@ -577,6 +659,12 @@ HTML-CIRCLE: <p></p>
HTML-CIRCLE: </div>
HTML-CIRCLE: <div>
HTML-CIRCLE: <p></p>
HTML-CIRCLE-NOT: </div>
HTML-CIRCLE-NOT: <h3>Parameters</h3>
HTML-CIRCLE-NOT: <div>
HTML-CIRCLE-NOT: <b>radius</b> <div>
HTML-CIRCLE-NOT: <p> Radius of the circle.</p>
HTML-CIRCLE-NOT: </div>
HTML-CIRCLE: </div>
HTML-CIRCLE: </div>
HTML-CIRCLE: </div>
Expand Down