[clang-tidy] Fix linking regression in clangTidyLLVMModule #150769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the regression introduced in llvm#149148 that incorrectly explicitly linked `clangTransformer` when dylib was used. As a result, the executables linking to `clangTidyLLVMModule` would end up linking both the dylib and a number of static clang libraries, leading to complete mayhem and undecipherable segmentation faults. Signed-off-by: Michał Górny <[email protected]>
Member
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Michał Górny (mgorny) ChangesFix the regression introduced in #149148 that incorrectly explicitly linked Full diff: https://github.com/llvm/llvm-project/pull/150769.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
index 4f1da43d3f1b7..41386cdb55b1f 100644
--- a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
@@ -17,7 +17,6 @@ add_clang_library(clangTidyLLVMModule STATIC
clangTidy
clangTidyReadabilityModule
clangTidyUtils
- clangTransformer
DEPENDS
omp_gen
@@ -31,4 +30,5 @@ clang_target_link_libraries(clangTidyLLVMModule
clangBasic
clangLex
clangTooling
+ clangTransformer
)
|
jpienaar
approved these changes
Jul 26, 2025
Member
Author
|
Thanks! |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Fix the regression introduced in llvm#149148 that incorrectly explicitly linked `clangTransformer` when dylib was used. As a result, the executables linking to `clangTidyLLVMModule` would end up linking both the dylib and a number of static clang libraries, leading to complete mayhem and undecipherable segmentation faults. Signed-off-by: Michał Górny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression introduced in #149148 that incorrectly explicitly linked
clangTransformerwhen dylib was used. As a result, the executables linking toclangTidyLLVMModulewould end up linking both the dylib and a number of static clang libraries, leading to complete mayhem and undecipherable segmentation faults.