[NFC][ELF] Don't duplicate DynamicReloc constructor #150811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
Member
|
@llvm/pr-subscribers-lld @llvm/pr-subscribers-lld-elf Author: Jessica Clarke (jrtc27) ChangesThis second constructor is just a shorthand for an AddendOnly relocation Full diff: https://github.com/llvm/llvm-project/pull/150811.diff 1 Files Affected:
diff --git a/lld/ELF/SyntheticSections.h b/lld/ELF/SyntheticSections.h
index 2e7a3c3bc96d2..24ca93fb2b16a 100644
--- a/lld/ELF/SyntheticSections.h
+++ b/lld/ELF/SyntheticSections.h
@@ -442,9 +442,8 @@ class DynamicReloc {
/// This constructor records a relative relocation with no symbol.
DynamicReloc(RelType type, const InputSectionBase *inputSec,
uint64_t offsetInSec, int64_t addend = 0)
- : sym(inputSec->getCtx().dummySym), inputSec(inputSec),
- offsetInSec(offsetInSec), type(type), addend(addend), kind(AddendOnly),
- expr(R_ADDEND) {}
+ : DynamicReloc(type, inputSec, offsetInSec, AddendOnly,
+ *inputSec->getCtx().dummySym, addend, R_ADDEND) {}
uint64_t getOffset() const;
uint32_t getSymIndex(SymbolTableBaseSection *symTab) const;
|
arichardson
approved these changes
Jul 27, 2025
MaskRay
approved these changes
Jul 27, 2025
Created using spr 1.3.5 [skip ci]
jrtc27
changed the base branch from
users/jrtc27/spr/main.nfcelf-dont-duplicate-dynamicreloc-constructor
to
main
jrtc27
deleted the
users/jrtc27/spr/nfcelf-dont-duplicate-dynamicreloc-constructor
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 30, 2025
This second constructor is just a shorthand for an AddendOnly relocation against dummySym with R_ADDEND, so write it as such. Reviewers: arichardson, MaskRay Reviewed By: MaskRay, arichardson Pull Request: llvm/llvm-project#150811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This second constructor is just a shorthand for an AddendOnly relocation
against dummySym with R_ADDEND, so write it as such.