Skip to content

[MLIR] Migrate InlinerInterfaceImpl to the new LDBG() debug form (NFC) #150853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

[MLIR] Migrate InlinerInterfaceImpl to the new LDBG() debug form (NFC) #150853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions mlir/lib/Dialect/LLVMIR/Transforms/InlinerInterfaceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#include "llvm/ADT/ScopeExit.h"
#include "llvm/Support/Debug.h"

#include "llvm/Support/DebugLog.h"

#define DEBUG_TYPE "llvm-inliner"

using namespace mlir;
Expand Down Expand Up @@ -670,44 +672,42 @@ struct LLVMInlinerInterface : public DialectInlinerInterface {
bool wouldBeCloned) const final {
auto callOp = dyn_cast<LLVM::CallOp>(call);
if (!callOp) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: call is not an '"
<< LLVM::CallOp::getOperationName() << "' op\n");
LDBG() << "Cannot inline: call is not an '"
<< LLVM::CallOp::getOperationName() << "' op";
return false;
}
if (callOp.getNoInline()) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: call is marked no_inline\n");
LDBG() << "Cannot inline: call is marked no_inline";
return false;
}
auto funcOp = dyn_cast<LLVM::LLVMFuncOp>(callable);
if (!funcOp) {
LLVM_DEBUG(llvm::dbgs()
<< "Cannot inline: callable is not an '"
<< LLVM::LLVMFuncOp::getOperationName() << "' op\n");
LDBG() << "Cannot inline: callable is not an '"
<< LLVM::LLVMFuncOp::getOperationName() << "' op";
return false;
}
if (funcOp.isNoInline()) {
LLVM_DEBUG(llvm::dbgs()
<< "Cannot inline: function is marked no_inline\n");
LDBG() << "Cannot inline: function is marked no_inline";
return false;
}
if (funcOp.isVarArg()) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: callable is variadic\n");
LDBG() << "Cannot inline: callable is variadic";
return false;
}
// TODO: Generate aliasing metadata from noalias result attributes.
if (auto attrs = funcOp.getArgAttrs()) {
for (DictionaryAttr attrDict : attrs->getAsRange<DictionaryAttr>()) {
if (attrDict.contains(LLVM::LLVMDialect::getInAllocaAttrName())) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline " << funcOp.getSymName()
<< ": inalloca arguments not supported\n");
LDBG() << "Cannot inline " << funcOp.getSymName()
<< ": inalloca arguments not supported";
return false;
}
}
}
// TODO: Handle exceptions.
if (funcOp.getPersonality()) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline " << funcOp.getSymName()
<< ": unhandled function personality\n");
LDBG() << "Cannot inline " << funcOp.getSymName()
<< ": unhandled function personality";
return false;
}
if (funcOp.getPassthrough()) {
Expand All @@ -717,10 +717,8 @@ struct LLVMInlinerInterface : public DialectInlinerInterface {
if (!stringAttr)
return false;
if (disallowedFunctionAttrs.contains(stringAttr)) {
LLVM_DEBUG(llvm::dbgs()
<< "Cannot inline " << funcOp.getSymName()
<< ": found disallowed function attribute "
<< stringAttr << "\n");
LDBG() << "Cannot inline " << funcOp.getSymName()
<< ": found disallowed function attribute " << stringAttr;
return true;
}
return false;
Expand Down