[utils][UpdateTestChecks] update_llc_test_checks.py - armv7-apple-darwin triple no longer working #150906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-backend-arm Author: woruyu (woruyu) ChangesSummaryThis PR resolves #150207 Full diff: https://github.com/llvm/llvm-project/pull/150906.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/ARM/fcopysign.ll b/llvm/test/CodeGen/ARM/fcopysign.ll
index b183418ca74f7..dbebe44740bbc 100644
--- a/llvm/test/CodeGen/ARM/fcopysign.ll
+++ b/llvm/test/CodeGen/ARM/fcopysign.ll
@@ -85,6 +85,7 @@ define float @test4() nounwind {
; SOFT-NEXT: vadd.f32 d0, d0, d16
; SOFT-NEXT: vmov r0, s0
; SOFT-NEXT: pop {lr}
+; SOFT-NEXT: bx lr
;
; HARD-LABEL: test4:
; HARD: @ %bb.0: @ %entry
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index c2829c1fed0ae..98b4b5da8a3df 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -165,12 +165,10 @@ class string:
)
ASM_FUNCTION_ARM_DARWIN_RE = re.compile(
- r"@[ \t]--[ \t]Begin[ \t]function[ \t](?P<func>[^ \t]+?)\n"
- r"^[ \t]*\.globl[ \t]*_(?P=func)[ \t]*"
+ r"^[ \t]*\.globl[ \t]*_(?P<func>[^ \t]+)[ \t]*\@[ \t]*--[ \t]Begin[ \t]function[ \t](?P=func)\n"
r"(?P<directives>.*?)"
- r"^_(?P=func):\n[ \t]*"
- r"(?P<body>.*?)"
- r"^[ \t]*@[ \t]--[ \t]End[ \t]function",
+ r"^_(?P=func):.*?\n"
+ r"(?P<body>.*?)(?=^[ \t]*@[ \t]--[ \t]End[ \t]function)",
flags=(re.M | re.S),
)
|
Member
|
@llvm/pr-subscribers-testing-tools Author: woruyu (woruyu) ChangesSummaryThis PR resolves #150207 Full diff: https://github.com/llvm/llvm-project/pull/150906.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/ARM/fcopysign.ll b/llvm/test/CodeGen/ARM/fcopysign.ll
index b183418ca74f7..dbebe44740bbc 100644
--- a/llvm/test/CodeGen/ARM/fcopysign.ll
+++ b/llvm/test/CodeGen/ARM/fcopysign.ll
@@ -85,6 +85,7 @@ define float @test4() nounwind {
; SOFT-NEXT: vadd.f32 d0, d0, d16
; SOFT-NEXT: vmov r0, s0
; SOFT-NEXT: pop {lr}
+; SOFT-NEXT: bx lr
;
; HARD-LABEL: test4:
; HARD: @ %bb.0: @ %entry
diff --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index c2829c1fed0ae..98b4b5da8a3df 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -165,12 +165,10 @@ class string:
)
ASM_FUNCTION_ARM_DARWIN_RE = re.compile(
- r"@[ \t]--[ \t]Begin[ \t]function[ \t](?P<func>[^ \t]+?)\n"
- r"^[ \t]*\.globl[ \t]*_(?P=func)[ \t]*"
+ r"^[ \t]*\.globl[ \t]*_(?P<func>[^ \t]+)[ \t]*\@[ \t]*--[ \t]Begin[ \t]function[ \t](?P=func)\n"
r"(?P<directives>.*?)"
- r"^_(?P=func):\n[ \t]*"
- r"(?P<body>.*?)"
- r"^[ \t]*@[ \t]--[ \t]End[ \t]function",
+ r"^_(?P=func):.*?\n"
+ r"(?P<body>.*?)(?=^[ \t]*@[ \t]--[ \t]End[ \t]function)",
flags=(re.M | re.S),
)
|
…win triple no longer working
woruyu
force-pushed
the
fix/update_llc_test_checks-armv7-apple-darwin
branch
from
ef59258 to
731cd26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #150207