Skip to content

Fix: Changed parameter to const reference instead of pass-by-value #150928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Changed parameter to const reference instead of pass-by-value #150928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da0c65f
Fix: Changed parameter to const reference instead of pass-by-value
arrowten Jul 28, 2025
6a50e14
Merge branch 'main' into fix/100524-clumsy-parameter-passing
arrowten Jul 28, 2025
a857be9
Merge branch 'main' into fix/100524-clumsy-parameter-passing
arrowten Jul 28, 2025
10eeaae
Merge branch 'main' into fix/100524-clumsy-parameter-passing
arrowten Jul 28, 2025
2af2627
Merge branch 'main' into fix/100524-clumsy-parameter-passing
arrowten Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/IR/Metadata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class DebugValueUser {
/// `resetDebugValue(Idx, NewDebugValue)` should be used instead.
LLVM_ABI void handleChangedValue(void *Old, Metadata *NewDebugValue);
DebugValueUser() = default;
explicit DebugValueUser(std::array<Metadata *, 3> DebugValues)
explicit DebugValueUser(const std::array<Metadata *, 3> &DebugValues)
: DebugValues(DebugValues) {
trackDebugValues();
}
Expand Down
25 changes: 25 additions & 0 deletions llvm/unittests/IR/MetadataTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5497,4 +5497,29 @@ TEST_F(MDTupleAllocationDeathTest, ResizeRejected) {
}
#endif

typedef MetadataTest DebugValueUserTest;

namespace {
struct DebugValueUserTestHelper: public llvm::DebugValueUser {
using llvm::DebugValueUser::DebugValueUser;
using llvm::DebugValueUser::getDebugValues;
};
}

TEST_F(DebugValueUserTest, GetDebugValues) {
auto *V = getConstantAsMetadata();
auto *V2 = getConstantAsMetadata();
auto *V3 = getConstantAsMetadata();
std::array<Metadata *, 3> Debugs = {V, V2, V3};
DebugValueUserTestHelper User(Debugs);
ArrayRef<Metadata *> Result = User.getDebugValues();

// Verify the size of the returned array is correct,
// and each element is correctly stored and returned.
EXPECT_EQ(Result.size(), 3u);
EXPECT_EQ(Result[0], V);
EXPECT_EQ(Result[1], V2);
EXPECT_EQ(Result[2], V3);
}

} // end namespace