release/21.x: [CI] Remove ccache from Linux CI Container #150942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes ccache from the Linux CI container. It is no longer needed after migrating the monolithic-linux.sh script. The other two upstream users of this container, namely the post commit static analyzer and the llvm tests workflow both already use sccache. Reviewers: tstellar, gburgessiv, dschuff, Keenuts, lnihlen, cmtice Reviewed By: dschuff, Keenuts, cmtice Pull Request: llvm#149197 (cherry picked from commit 0f3c94a)
Member
Author
|
@Keenuts What do you think about merging this PR to the release branch? |
Member
Author
|
@llvm/pr-subscribers-github-workflow Author: None (llvmbot) ChangesBackport 0f3c94a Requested by: @boomanaiden154 Full diff: https://github.com/llvm/llvm-project/pull/150942.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index efe08ebc221c5..6d4bcb3d1add2 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -58,10 +58,8 @@ RUN apt-get update && \
python3-psutil \
sudo \
# These are needed by the premerge pipeline. Pip is used to install
- # dependent python packages and ccache is used for build caching. File and
- # tzdata are used for tests.
+ # dependent python packages. File and tzdata are used for tests.
python3-pip \
- ccache \
file \
tzdata \
sccache && \
|
Contributor
|
Wrong patch, this doesn't actually do anything in the release branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0f3c94a
Requested by: @boomanaiden154