[lldb][cmake] Create dependencies for LLDB header targets #150995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those dependencies.
|
@llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) ChangesThe LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those dependencies. Full diff: https://github.com/llvm/llvm-project/pull/150995.diff 1 Files Affected:
diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt
index 0687c8444a4cb..fdd6b3b077463 100644
--- a/lldb/source/API/CMakeLists.txt
+++ b/lldb/source/API/CMakeLists.txt
@@ -327,6 +327,7 @@ foreach(header
endif()
add_custom_target(liblldb-stage-header-${basename} DEPENDS ${staged_header})
+ add_dependencies(liblldb-stage-header-${basename} lldb-sbapi-dwarf-enums)
add_dependencies(liblldb-header-staging liblldb-stage-header-${basename})
add_custom_command(
DEPENDS ${header} OUTPUT ${staged_header}
@@ -339,6 +340,7 @@ foreach(header
set(output_header $<TARGET_FILE_DIR:liblldb>/Headers/${basename})
add_custom_target(lldb-framework-fixup-header-${basename} DEPENDS ${staged_header})
+ add_dependencies(lldb-framework-fixup-header-${basename} liblldb-stage-header-${basename})
add_dependencies(lldb-framework-fixup-all-headers lldb-framework-fixup-header-${basename})
add_custom_command(TARGET lldb-framework-fixup-header-${basename} POST_BUILD
|
|
This fixes the error that I was having with CMaking the standalone build. |
|
Thanks for the confirmation Jim! |
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 4, 2025
The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those dependencies. (cherry picked from commit c162846)
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 4, 2025
[lldb][cmake] Create dependencies for LLDB header targets (llvm#150995)
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 11, 2025
…vm#150995)" This reverts commit c162846.
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 11, 2025
The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those dependencies. (cherry picked from commit c162846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those dependencies.