Skip to content

[WebAssembly] Add gc target feature to addBleedingEdgeFeatures #151107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

[WebAssembly] Add gc target feature to addBleedingEdgeFeatures #151107

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb71b47
[WebAssembly] Add gc target feature to addBleedingEdgeFeatures
hoodmane Jul 29, 2025
c0b039a
Alphebetize gc feature in list
hoodmane Jul 29, 2025
a5ba76c
Alphebetize more
hoodmane Jul 29, 2025
380b766
More updates
hoodmane Jul 29, 2025
d9833d5
Add gc test to wasm-features.c
hoodmane Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/Basic/Targets/WebAssembly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ bool WebAssemblyTargetInfo::initFeatureMap(
Features["multimemory"] = true;
Features["tail-call"] = true;
Features["wide-arithmetic"] = true;
Features["gc"] = true;
Copy link
Collaborator

@sbc100 sbc100 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to see a corresponding test change, is there not test that needs updating?

Copy link
Contributor Author

@hoodmane hoodmane Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... the CI didn't fail... so maybe not? This might be completely redundant with:
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/WebAssembly/WebAssembly.td?plain=1#L139-L146
so it suffices to add the feature in either of these two places.

Copy link
Collaborator

@sbc100 sbc100 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thats really the case we should remove the duplication.

setSIMDLevel(Features, RelaxedSIMD, true);
};
if (CPU == "generic") {
Expand Down