Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,14 @@ BasicBlock *
llvm::SplitKnownCriticalEdge(Instruction *TI, unsigned SuccNum,
const CriticalEdgeSplittingOptions &Options,
const Twine &BBName) {
assert(!isa<IndirectBrInst>(TI) &&
"Cannot split critical edge from IndirectBrInst");

BasicBlock *TIBB = TI->getParent();
BasicBlock *DestBB = TI->getSuccessor(SuccNum);

// Splitting the critical edge to a pad block is non-trivial. Don't do
// it in this generic function.
if (DestBB->isEHPad()) return nullptr;
// Splitting the critical edge to a pad block is non-trivial.
// And we cannot split block with IndirectBr as a terminator.
// Don't do it in this generic function.
if (DestBB->isEHPad() || isa<IndirectBrInst>(TI))
return nullptr;

if (Options.IgnoreUnreachableDests &&
isa<UnreachableInst>(DestBB->getFirstNonPHIOrDbgOrLifetime()))
Expand Down
19 changes: 19 additions & 0 deletions llvm/test/Transforms/GVN/cond_br.ll
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,22 @@ if.end: ; preds = %if.else, %if.then
}

declare void @bar(i32)

define void @indirectbr_could_not_split() {
; CHECK-LABEL: define void @indirectbr_could_not_split() {
; CHECK-NEXT: [[ENTRY:.*:]]
; CHECK-NEXT: br i1 false, label %[[IBR:.*]], label %[[EXIT:.*]]
; CHECK: [[IBR]]:
; CHECK-NEXT: indirectbr ptr null, [label %[[EXIT]], label %exit]
; CHECK: [[EXIT]]:
; CHECK-NEXT: ret void
;
entry:
br i1 false, label %ibr, label %exit

ibr:
indirectbr ptr null, [label %exit, label %exit]

exit:
ret void
}