Skip to content

[lldb][test][NFC] Add LLDB test for UBSan trap frame recognizer #151231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged

[lldb][test][NFC] Add LLDB test for UBSan trap frame recognizer #151231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdf7487
Add test for UBSan trap frame recognizer
anthonyhatran Jul 29, 2025
3623b01
Address all comments
anthonyhatran Jul 30, 2025
f2f1b62
Re-add frame info line
anthonyhatran Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lldb/test/Shell/Recognizer/Inputs/ubsan_add_overflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#include <limits.h>

int main() {
volatile int a = INT_MAX;
volatile int b = 1;
volatile int c = a + b;
return c;
Copy link
Collaborator

@DavidSpickett DavidSpickett Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be done in one line. return INT_MAX + 1; assuming INT_MAX defaults to unsigned int still.

Copy link
Contributor Author

@anthonyhatran anthonyhatran Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it into one line.

}
17 changes: 17 additions & 0 deletions lldb/test/Shell/Recognizer/ubsan_add_overflow.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# REQUIRES: clang

# RUN: %clang_host -g -O0 %S/Inputs/ubsan_add_overflow.cpp -o %t.out \
Copy link
Collaborator

@DavidSpickett DavidSpickett Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have a feeling this doesn't need to be host, because the shell tests can be run remotely. I looked at the other tests and they are all %clang_host though.

So this is not an issue with this test it's with a category of tests. Which is not your responsibility, so you don't need to change anything here.

# RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow
Copy link
Member

@Michael137 Michael137 Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets indent here to make it easier to read

Suggested change
# RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow
# RUN: -fsanitize=signed-integer-overflow -fsanitize-trap=signed-integer-overflow

Copy link
Contributor Author

@anthonyhatran anthonyhatran Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added


# RUN: %lldb -b -s %s %t.out | FileCheck %s

run
# CHECK: thread #{{.*}} stop reason = Undefined Behavior Sanitizer: Integer addition overflowed

frame info
# CHECK: frame #{{.*}}`main at ubsan_add_overflow.cpp

frame recognizer info 0
# CHECK: frame 0 is recognized by Verbose Trap StackFrame Recognizer

quit
Loading