Skip to content

[mlir][scf] Add no_inline attribute to scf.execute_region #151352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

[mlir][scf] Add no_inline attribute to scf.execute_region #151352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c83c3d
[mlir][scf] Add `no_inline` attribute to `scf.execute_region`
jungpark-mlir Jul 30, 2025
21c92a2
Let attribute as a keyword
jungpark-mlir Jul 30, 2025
3564d75
format
jungpark-mlir Jul 30, 2025
03a3c0b
Revised dosument from the review.
jungpark-mlir Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ def ExecuteRegionOp : SCF_Op<"execute_region", [
be accessed inside the op. The op's region can have multiple blocks and the
blocks can have multiple distinct terminators. Values returned from this op's
region define the op's results.
Canonicalizer inlines an ExecuteRegionOp into its parent if it only contains
one block or its parent can contain multiple blocks, 'no_inline' attribute
can be set to prevent an ExecuteRegionOp from being inlined.
Copy link
Collaborator

@joker-eph joker-eph Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird to describe an op semantics in terms of a specific pass.

Suggested change
Canonicalizer inlines an ExecuteRegionOp into its parent if it only contains
one block or its parent can contain multiple blocks, 'no_inline' attribute
can be set to prevent an ExecuteRegionOp from being inlined.
The optional 'no_inline' flag can be set to request the ExecuteRegionOp to be
preserved as much as possible and not being inlined in the parent block until
an explicit lowering step.

Copy link
Contributor Author

@jungpark-mlir jungpark-mlir Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, thanks!


Example:

Expand All @@ -98,6 +101,14 @@ def ExecuteRegionOp : SCF_Op<"execute_region", [
}
}

// the same as above but with no_inline attribute
scf.for %i = 0 to 128 step %c1 {
%y = scf.execute_region -> i32 no_inline {
%x = load %A[%i] : memref<128xi32>
scf.yield %x : i32
}
}

affine.for %i = 0 to 100 {
"foo"() : () -> ()
%v = scf.execute_region -> i64 {
Expand Down
6 changes: 5 additions & 1 deletion mlir/lib/Dialect/SCF/IR/SCF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ ParseResult ExecuteRegionOp::parse(OpAsmParser &parser,
if (parser.parseOptionalArrowTypeList(result.types))
return failure();

if (succeeded(parser.parseOptionalKeyword("no_inline")))
result.addAttribute("no_inline", parser.getBuilder().getUnitAttr());

// Introduce the body region and parse it.
Region *body = result.addRegion();
if (parser.parseRegion(*body, /*arguments=*/{}, /*argTypes=*/{}) ||
Expand All @@ -148,8 +151,9 @@ ParseResult ExecuteRegionOp::parse(OpAsmParser &parser,

void ExecuteRegionOp::print(OpAsmPrinter &p) {
p.printOptionalArrowTypeList(getResultTypes());

p << ' ';
if(getNoInline())
p << "no_inline ";
p.printRegion(getRegion(),
/*printEntryBlockArgs=*/false,
/*printBlockTerminators=*/true);
Expand Down
20 changes: 10 additions & 10 deletions mlir/test/Dialect/SCF/canonicalize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,8 +1440,8 @@ func.func @propagate_into_execute_region() {

// -----

// CHECK-LABEL: func @execute_region_elim
func.func @execute_region_elim() {
// CHECK-LABEL: func @execute_region_inline
func.func @execute_region_inline() {
affine.for %i = 0 to 100 {
"test.foo"() : () -> ()
%v = scf.execute_region -> i64 {
Expand All @@ -1461,14 +1461,14 @@ func.func @execute_region_elim() {

// -----

// CHECK-LABEL: func @execute_region_elim_noinline
func.func @execute_region_elim_noinline() {
// CHECK-LABEL: func @execute_region_no_inline
func.func @execute_region_no_inline() {
affine.for %i = 0 to 100 {
"test.foo"() : () -> ()
%v = scf.execute_region -> i64 {
%v = scf.execute_region -> i64 no_inline {
%x = "test.val"() : () -> i64
scf.yield %x : i64
} {no_inline}
}
"test.bar"(%v) : (i64) -> ()
}
return
Expand All @@ -1483,8 +1483,8 @@ func.func @execute_region_elim_noinline() {

// -----

// CHECK-LABEL: func @func_execute_region_elim
func.func @func_execute_region_elim() {
// CHECK-LABEL: func @func_execute_region_inline
func.func @func_execute_region_inline() {
"test.foo"() : () -> ()
%v = scf.execute_region -> i64 {
%c = "test.cmp"() : () -> i1
Expand Down Expand Up @@ -1518,8 +1518,8 @@ func.func @func_execute_region_elim() {

// -----

// CHECK-LABEL: func @func_execute_region_elim_multi_yield
func.func @func_execute_region_elim_multi_yield() {
// CHECK-LABEL: func @func_execute_region_inline_multi_yield
func.func @func_execute_region_inline_multi_yield() {
"test.foo"() : () -> ()
%v = scf.execute_region -> i64 {
%c = "test.cmp"() : () -> i1
Expand Down
Loading