Skip to content

[lldb] Fallback to expression eval when Dump of variable fails in dwim-print #151374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

[lldb] Fallback to expression eval when Dump of variable fails in dwim-print #151374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b65cb
[lldb] Fallback to expression eval when Dump of variable fails in dwi…
kastiglione Jul 30, 2025
2fe7671
Log non-fatal errors
kastiglione Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions lldb/source/Commands/CommandObjectDWIMPrint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "lldb/lldb-enumerations.h"
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"

#include <regex>

Expand Down Expand Up @@ -132,27 +133,22 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
};

// Dump `valobj` according to whether `po` was requested or not.
auto dump_val_object = [&](ValueObject &valobj) {
auto dump_val_object = [&](ValueObject &valobj) -> Error {
if (is_po) {
StreamString temp_result_stream;
if (llvm::Error error = valobj.Dump(temp_result_stream, dump_options)) {
result.AppendError(toString(std::move(error)));
return;
}
if (Error err = valobj.Dump(temp_result_stream, dump_options))
return err;
llvm::StringRef output = temp_result_stream.GetString();
maybe_add_hint(output);
result.GetOutputStream() << output;
} else {
llvm::Error error =
valobj.Dump(result.GetOutputStream(), dump_options);
if (error) {
result.AppendError(toString(std::move(error)));
return;
}
if (Error err = valobj.Dump(result.GetOutputStream(), dump_options))
return err;
}
m_interpreter.PrintWarningsIfNecessary(result.GetOutputStream(),
m_cmd_name);
result.SetStatus(eReturnStatusSuccessFinishResult);
return Error::success();
};

// First, try `expr` as a _limited_ frame variable expression path: only the
Expand Down Expand Up @@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
expr);
}

dump_val_object(*valobj_sp);
return;
bool failed = errorToBool(dump_val_object(*valobj_sp));
if (!failed)
return;

// Dump failed, continue on to expression evaluation.
}
}

Expand All @@ -196,8 +195,9 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
if (auto *state = target.GetPersistentExpressionStateForLanguage(language))
if (auto var_sp = state->GetVariable(expr))
if (auto valobj_sp = var_sp->GetValueObject()) {
dump_val_object(*valobj_sp);
return;
bool failed = errorToBool(dump_val_object(*valobj_sp));
if (!failed)
return;
}

// Third, and lastly, try `expr` as a source expression to evaluate.
Expand Down Expand Up @@ -248,10 +248,12 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
result.AppendNoteWithFormatv("ran `expression {0}{1}`", flags, expr);
}

if (valobj_sp->GetError().GetError() != UserExpression::kNoResult)
dump_val_object(*valobj_sp);
else
if (valobj_sp->GetError().GetError() != UserExpression::kNoResult) {
if (Error err = dump_val_object(*valobj_sp))
result.SetError(std::move(err));
} else {
result.SetStatus(eReturnStatusSuccessFinishNoResult);
}

if (suppress_result)
if (auto result_var_sp =
Expand Down
Loading