Skip to content

[mlir][vector] Add alignment attribute to maskedload and maskedstore #151690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 8, 2025
Merged

[mlir][vector] Add alignment attribute to maskedload and maskedstore #151690

Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
96ba831
[mlir][vector] Add alignment to maskedload.
amd-eochoalo Jul 30, 2025
9958c24
[mlir][vector] Add alignment to maskedstore.
amd-eochoalo Jul 31, 2025
b2f70ff
[mlir] Use alignment in VectorToLLVM conversion.
amd-eochoalo Jul 31, 2025
0eb1b44
Remove unnecessary checks in test
amd-eochoalo Aug 5, 2025
56c2335
Make operations parameters in test
amd-eochoalo Aug 5, 2025
c0f3d68
Rename test functions to be consistent
amd-eochoalo Aug 5, 2025
bcdd88a
Change expected-error@+1 to expected-error@below
amd-eochoalo Aug 5, 2025
55c9c3f
Change function name
amd-eochoalo Aug 5, 2025
3e79681
Simplify types in test
amd-eochoalo Aug 5, 2025
8c65e3d
Add AlignmentBytes class
amd-eochoalo Aug 5, 2025
3a7eeae
Outline getting alignment from load or store op
amd-eochoalo Aug 5, 2025
85376c3
Use value instead of value_or
amd-eochoalo Aug 5, 2025
125a84e
Revert "Use value instead of value_or"
amd-eochoalo Aug 7, 2025
2c8181e
Revert "Outline getting alignment from load or store op"
amd-eochoalo Aug 7, 2025
6bcf13d
Revert "Add AlignmentBytes class"
amd-eochoalo Aug 7, 2025
577e612
Change name of tests
amd-eochoalo Aug 7, 2025
c661019
Use llvm::Align
amd-eochoalo Aug 6, 2025
638df9a
style
amd-eochoalo Aug 7, 2025
d5f19c3
Use llvm::Align with masked operations
amd-eochoalo Aug 7, 2025
8b2b222
Merge branch 'main' into eochoa/2025-07-30/propagate-alignment-vector…
amd-eochoalo Aug 7, 2025
403a114
Use llvm::MaybeAlign instead of llvm::Align
amd-eochoalo Aug 8, 2025
8b3a0fd
Apply suggestions from review
amd-eochoalo Aug 8, 2025
af3aba3
use -> instead of *
amd-eochoalo Aug 8, 2025
4ea2a33
Add missing tests for vector.{load,store}
amd-eochoalo Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,18 +1729,18 @@ def Vector_LoadOp : Vector_Op<"load", [
"Value":$base,
"ValueRange":$indices,
CArg<"bool", "false">:$nontemporal,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, resultType, base, indices, nontemporal,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>,
OpBuilder<(ins "TypeRange":$resultTypes,
"Value":$base,
"ValueRange":$indices,
CArg<"bool", "false">:$nontemporal,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, resultTypes, base, indices, nontemporal,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>
];
Expand Down Expand Up @@ -1847,9 +1847,9 @@ def Vector_StoreOp : Vector_Op<"store", [
"Value":$base,
"ValueRange":$indices,
CArg<"bool", "false">:$nontemporal,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, valueToStore, base, indices, nontemporal,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>
];
Expand Down Expand Up @@ -1947,19 +1947,19 @@ def Vector_MaskedLoadOp :
"ValueRange":$indices,
"Value":$mask,
"Value":$passthrough,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, resultType, base, indices, mask, passthrough,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>,
OpBuilder<(ins "TypeRange":$resultTypes,
"Value":$base,
"ValueRange":$indices,
"Value":$mask,
"Value":$passthrough,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, resultTypes, base, indices, mask, passthrough,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>
];
Expand Down Expand Up @@ -2037,9 +2037,9 @@ def Vector_MaskedStoreOp :
"ValueRange":$indices,
"Value":$mask,
"Value":$valueToStore,
CArg<"llvm::Align", "llvm::Align()">:$alignment), [{
CArg<"llvm::MaybeAlign", "llvm::MaybeAlign()">:$alignment), [{
return build($_builder, $_state, base, indices, mask, valueToStore,
alignment != llvm::Align() ? $_builder.getI64IntegerAttr(alignment.value()) :
alignment != llvm::MaybeAlign() ? $_builder.getI64IntegerAttr(alignment.valueOrOne().value()) :
nullptr);
}]>
];
Expand Down