-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[libc++][ranges] Ensure range access CPOs are provided in <iterator>
#151745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frederick-vs-ja
merged 4 commits into
llvm:main
from
frederick-vs-ja:ranges-cpo-in-iterator
Aug 18, 2025
+82
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d73c62f
[libc++][ranges] Ensure range access CPOs are provided in `<iterator>`
frederick-vs-ja 48bdb72
Revert changes in `<ranges>`
frederick-vs-ja bd0ac1c
Actually call CPOs in the test, at both compile- and run-time
frederick-vs-ja 83ad269
Merge branch 'main' into ranges-cpo-in-iterator
frederick-vs-ja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
libcxx/test/std/ranges/range.access/include.iterator.pass.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// REQUIRES: std-at-least-c++20 | ||
|
||
// [range.access.general]/1: | ||
// In addition to being available via inclusion of the <ranges> header, the customization point objects in | ||
// [range.access] are available when the header <iterator> is included. | ||
|
||
#include <iterator> | ||
#include <type_traits> | ||
|
||
#include "test_macros.h" | ||
|
||
template <class CPO, class... Args> | ||
constexpr void test(CPO& o, Args&&... args) { | ||
static_assert(std::is_const_v<CPO>); | ||
static_assert(std::is_class_v<CPO>); | ||
static_assert(std::is_trivially_copyable_v<CPO>); | ||
static_assert(std::is_trivially_default_constructible_v<CPO>); | ||
|
||
auto p = o; | ||
using T = decltype(p); | ||
(void)o(args...); // to make sure the CPO can actually be used | ||
|
||
// The type of a customization point object, ignoring cv-qualifiers, shall model semiregular. | ||
static_assert(std::semiregular<T>); | ||
|
||
// The type T of a customization point object, ignoring cv-qualifiers, shall model... | ||
static_assert(std::invocable<T&, Args...>); | ||
static_assert(std::invocable<const T&, Args...>); | ||
static_assert(std::invocable<T, Args...>); | ||
static_assert(std::invocable<const T, Args...>); | ||
} | ||
|
||
int a[10]; | ||
|
||
constexpr bool test() { | ||
test(std::ranges::begin, a); | ||
test(std::ranges::end, a); | ||
test(std::ranges::cbegin, a); | ||
test(std::ranges::cdata, a); | ||
test(std::ranges::cend, a); | ||
test(std::ranges::crbegin, a); | ||
test(std::ranges::crend, a); | ||
test(std::ranges::data, a); | ||
test(std::ranges::empty, a); | ||
test(std::ranges::rbegin, a); | ||
test(std::ranges::rend, a); | ||
test(std::ranges::size, a); | ||
test(std::ranges::ssize, a); | ||
|
||
#if TEST_STD_VER >= 26 | ||
// test(std::views::reserve_hint, a); | ||
#endif | ||
|
||
return true; | ||
} | ||
|
||
int main() { | ||
test(); | ||
static_assert(test()); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.