-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Add vector-based strlen implementation for x86_64 and aarch64 #152389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
9a4760a
6a1f6dd
fd74316
863ad74
d9889cd
ac36e4a
61e0181
d616a95
6d23ff3
9c0d577
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
//===-- Strlen implementation for aarch64 ---------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
#ifndef LLVM_LIBC_SRC_STRING_MEMORY_UTILS_AARCH64_INLINE_STRLEN_H | ||
#define LLVM_LIBC_SRC_STRING_MEMORY_UTILS_AARCH64_INLINE_STRLEN_H | ||
|
||
#if defined(__ARM_NEON) | ||
#include "src/__support/CPP/bit.h" // countr_zero | ||
|
||
#include <arm_neon.h> | ||
#include <stddef.h> // size_t | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
namespace neon { | ||
[[maybe_unused]] LIBC_INLINE size_t string_length(const char *src) { | ||
using Vector __attribute__((may_alias)) = uint8x8_t; | ||
|
||
uintptr_t misalign_bytes = reinterpret_cast<uintptr_t>(src) % sizeof(Vector); | ||
Vector *block_ptr = reinterpret_cast<Vector *>(src - misalign_bytes); | ||
Vector v = *block_ptr; | ||
Vector vcmp = vceqz_u8(v); | ||
uint64x1_t cmp_mask = vreinterpret_u64_s8(vcmp); | ||
uint64_t cmp = vget_lane_u64(cmp_mask, 0); | ||
cmp = cmp >> (misalign_bytes << 3); | ||
if (cmp) | ||
return cpp::countr_zero(cmp) >> 3; | ||
|
||
while (true) { | ||
++block_ptr; | ||
v = *block_ptr; | ||
vcmp = vceqz_u8(v); | ||
cmp_mask = vreinterpret_u64_s8(vcmp); | ||
cmp = vget_lane_u64(cmp_mask, 0); | ||
if (cmp) | ||
return static_cast<size_t>(reinterpret_cast<uintptr_t>(block_ptr) - | ||
reinterpret_cast<uintptr_t>(src) + | ||
(cpp::countr_zero(cmp) >> 3)); | ||
} | ||
} | ||
} // namespace neon | ||
|
||
namespace string_length_impl = neon; | ||
|
||
} // namespace LIBC_NAMESPACE_DECL | ||
#endif // __ARM_NEON | ||
#endif // LLVM_LIBC_SRC_STRING_MEMORY_UTILS_AARCH64_INLINE_STRLEN_H |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
//===-- Strlen implementation for x86_64 ----------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
#ifndef LLVM_LIBC_SRC_STRING_MEMORY_UTILS_X86_64_INLINE_STRLEN_H | ||
#define LLVM_LIBC_SRC_STRING_MEMORY_UTILS_X86_64_INLINE_STRLEN_H | ||
|
||
#include "src/__support/CPP/bit.h" // countr_zero | ||
|
||
#include <immintrin.h> | ||
#include <stddef.h> // size_t | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
|
||
namespace sse2 { | ||
[[maybe_unused]] LIBC_INLINE size_t string_length(const char *src) { | ||
using Vector __attribute__((may_alias)) = __m128i; | ||
|
||
Vector z = _mm_setzero_si128(); | ||
uintptr_t misalign_bytes = reinterpret_cast<uintptr_t>(src) % sizeof(Vector); | ||
const Vector *block_ptr = | ||
reinterpret_cast<const Vector *>(src - misalign_bytes); | ||
Vector v = _mm_load_si128(block_ptr); | ||
Vector vcmp = _mm_cmpeq_epi8(z, v); | ||
// shift away results in irrelevant bytes. | ||
uint32_t cmp = _mm_movemask_epi8(vcmp) >> misalign_bytes; | ||
if (cmp) | ||
return cpp::countr_zero(cmp); | ||
|
||
while (true) { | ||
block_ptr++; | ||
v = _mm_load_si128(block_ptr); | ||
vcmp = _mm_cmpeq_epi8(z, v); | ||
cmp = _mm_movemask_epi8(vcmp); | ||
if (cmp) | ||
return static_cast<size_t>(reinterpret_cast<uintptr_t>(block_ptr) - | ||
reinterpret_cast<uintptr_t>(src) + | ||
cpp::countr_zero(cmp)); | ||
} | ||
} | ||
} // namespace sse2 | ||
|
||
#if defined(__AVX2__) | ||
namespace avx2 { | ||
[[maybe_unused]] LIBC_INLINE size_t string_length(const char *src) { | ||
using Vector __attribute__((may_alias)) = __mm256i; | ||
|
||
Vector z = _mm256_setzero_si256(); | ||
uintptr_t misalign_bytes = reinterpret_cast<uintptr_t>(src) % sizeof(Vector); | ||
const Vector *block_ptr = | ||
reinterpret_cast<const Vector *>(src - misalign_bytes); | ||
Vector v = _mm256_load_si256(block_ptr); | ||
Vector vcmp = _mm256_cmpeq_epi8(z, v); | ||
// shift away results in irrelevant bytes. | ||
int cmp = _mm256_movemask_epi8(vcmp) >> misalign_bytes; | ||
if (cmp) | ||
return cpp::countr_zero(cmp); | ||
|
||
while (true) { | ||
block_ptr++; | ||
v = _mm256_load_si256(block_ptr); | ||
vcmp = _mm256_cmpeq_epi8(z, v); | ||
cmp = _mm256_movemask_epi8(vcmp); | ||
if (cmp) | ||
return static_cast<size_t>(reinterpret_cast<uintptr_t>(block_ptr) - | ||
reinterpret_cast<uintptr_t>(src) + | ||
cpp::countr_zero(cmp)); | ||
} | ||
} | ||
} // namespace avx2 | ||
#endif | ||
|
||
#if defined(__AVX512F__) | ||
namespace avx512 { | ||
[[maybe_unused]] LIBC_INLINE size_t string_length(const char *src) { | ||
using Vector __attribute__((may_alias)) = __mm512i; | ||
|
||
Vector z = _mm512_setzero_si512(); | ||
uintptr_t misalign_bytes = reinterpret_cast<uintptr_t>(src) % sizeof(Vector); | ||
const Vector *block_ptr = | ||
reinterpret_cast<const Vector *>(src - misalign_bytes); | ||
Vector v = _mm512_load_si512(block_ptr); | ||
__mmask64 cmp = _mm512_cmp_epu8_mask(z, v, _MM_CMPINT_EQ) >> misalign_bytes; | ||
if (cmp) | ||
return cpp::countr_zero(cmp); | ||
|
||
while (true) { | ||
block_ptr++; | ||
Vector v = _mm512_load_si512(block_ptr); | ||
__mmask64 cmp = _mm512_cmp_epu8_mask(z, v, _MM_CMPINT_EQ); | ||
if (cmp) | ||
return static_cast<size_t>(reinterpret_cast<uintptr_t>(block_ptr) - | ||
reinterpret_cast<uintptr_t>(src) + | ||
cpp::countr_zero(cmp)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: the avx2 and avx512 versions look almost identical except for the specific vector instructions. Is it possible to unify them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All three x86-implementations are nearly identical, but also all have subtle differences I have refactored to a template-based system. There is probably some way to combine the clang-native-vector and the aarch64 implementation into this template-system as well, but each one is just subtly different, so add more parameters, because the masking is different. I'm not sure it is particularly better, let me know what you think. |
||
} | ||
} | ||
} // namespace avx512 | ||
#endif | ||
|
||
#if defined(__AVX512F__) | ||
namespace string_length_impl = avx512; | ||
#elif defined(__AVX2__) | ||
namespace string_length_impl = avx2; | ||
#else | ||
namespace string_length_impl = sse2; | ||
#endif | ||
|
||
} // namespace LIBC_NAMESPACE_DECL | ||
|
||
#endif // LLVM_LIBC_SRC_STRING_MEMORY_UTILS_X86_64_INLINE_STRLEN_H |
Uh oh!
There was an error while loading. Please reload this page.