Skip to content

[libc] Move CharacterConverter template specialization to cpp file #152405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[libc] Move CharacterConverter template specialization to cpp file #152405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libc/src/__support/wchar/character_converter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,13 @@ ErrorOr<char8_t> CharacterConverter::pop_utf8() {
return static_cast<char8_t>(output);
}

template <> ErrorOr<char8_t> CharacterConverter::pop() { return pop_utf8(); }
template <> ErrorOr<char32_t> CharacterConverter::pop() { return pop_utf32(); }

template <> size_t CharacterConverter::sizeAs<char8_t>() {
return state->total_bytes;
}
template <> size_t CharacterConverter::sizeAs<char32_t>() { return 1; }

} // namespace internal
} // namespace LIBC_NAMESPACE_DECL
4 changes: 0 additions & 4 deletions libc/src/__support/wchar/character_converter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,13 @@ class CharacterConverter {
bool isValidState();

template <typename CharType> size_t sizeAs();
template <> size_t sizeAs<char8_t>() { return state->total_bytes; }
template <> size_t sizeAs<char32_t>() { return 1; }

int push(char8_t utf8_byte);
int push(char32_t utf32);

ErrorOr<char8_t> pop_utf8();
ErrorOr<char32_t> pop_utf32();
template <typename CharType> ErrorOr<CharType> pop();
template <> ErrorOr<char8_t> pop() { return pop_utf8(); }
template <> ErrorOr<char32_t> pop() { return pop_utf32(); }
};

} // namespace internal
Expand Down
Loading