Skip to content

[lldb] Print ValueObject when GetObjectDescription fails #152417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2025
Merged

[lldb] Print ValueObject when GetObjectDescription fails #152417

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93c8135
[lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescrip…
kastiglione Aug 7, 2025
ce204ae
Rework handling of po failure
kastiglione Aug 14, 2025
aeb1e40
reset correct name option
kastiglione Aug 14, 2025
7db9914
remove leftover #include
kastiglione Aug 14, 2025
f54992a
add test for failing description
kastiglione Aug 14, 2025
532bfea
add test for struct description
kastiglione Aug 14, 2025
22d657c
rename "use objc" to "use object description"
kastiglione Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lldb/source/DataFormatters/ValueObjectPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "lldb/DataFormatters/ValueObjectPrinter.h"

#include "lldb/DataFormatters/DataVisualization.h"
#include "lldb/Expression/DiagnosticManager.h"
#include "lldb/Interpreter/CommandInterpreter.h"
#include "lldb/Target/Language.h"
#include "lldb/Target/Target.h"
Expand Down Expand Up @@ -150,6 +151,11 @@ llvm::Expected<std::string> ValueObjectPrinter::GetDescriptionForDisplay() {
if (maybe_str)
return maybe_str;

if (maybe_str.errorIsA<lldb_private::ExpressionError>())
// Propagate expression errors to expose diagnostics to the user.
// Without this early exit, the summary/value may be shown without errors.
return maybe_str;

Copy link
Collaborator

@adrian-prantl adrian-prantl Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be testable by running an expression that fails reliably? For example by implementing a [-description] method that crashes?

Copy link
Contributor Author

@kastiglione kastiglione Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no

Copy link
Contributor Author

@kastiglione kastiglione Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrian-prantl I've added a test for this with the recent reworking. See TestObjCFailingDescription.py

const char *str = nullptr;
if (!str)
str = valobj.GetSummaryAsCString();
Expand Down
Loading