-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[LV] Add initial legality checks for loops with unbound loads. #152422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arcbbb
wants to merge
7
commits into
llvm:main
Choose a base branch
from
arcbbb:legality-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dc5b7c1
[LV] Add initial legality checks for loops with non-dereferenceable l…
arcbbb 78f05df
Fix braces
arcbbb f5315f8
Limit to single unbound access. Add tests
arcbbb d3246bd
clang-formatted
arcbbb eb316ee
trivial fix: use lower case
arcbbb faa6112
trivial fix
arcbbb b206c9f
Address comment and refine TTI to check data type
arcbbb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -870,3 +870,19 @@ bool llvm::isDereferenceableReadOnlyLoop( | |
} | ||
return true; | ||
} | ||
|
||
bool llvm::isReadOnlyLoopWithSafeOrSpeculativeLoads( | ||
arcbbb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Loop *L, ScalarEvolution *SE, DominatorTree *DT, AssumptionCache *AC, | ||
SmallVectorImpl<LoadInst *> *SpeculativeLoads, | ||
SmallVectorImpl<const SCEVPredicate *> *Predicates) { | ||
for (BasicBlock *BB : L->blocks()) { | ||
for (Instruction &I : *BB) { | ||
if (auto *LI = dyn_cast<LoadInst>(&I)) { | ||
if (!isDereferenceableAndAlignedInLoop(LI, L, *SE, *DT, AC, Predicates)) | ||
SpeculativeLoads->push_back(LI); | ||
} else if (I.mayReadFromMemory() || I.mayWriteToMemory() || I.mayThrow()) | ||
return false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Braces There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. Thanks! |
||
} | ||
} | ||
return true; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.