Skip to content

[analyzer] Detect use-after-free for field address (e.g., &ptr->field) #152462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3156,7 +3156,7 @@ void MallocChecker::checkPreCall(const CallEvent &Call,
for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) {
SVal ArgSVal = Call.getArgSVal(I);
if (isa<Loc>(ArgSVal)) {
SymbolRef Sym = ArgSVal.getAsSymbol();
SymbolRef Sym = ArgSVal.getAsSymbol(/*IncludeBaseRegions=*/true);
if (!Sym)
continue;
if (checkUseAfterFree(Sym, C, Call.getArgExpr(I)))
Expand Down
44 changes: 44 additions & 0 deletions clang/test/Analysis/malloc-checker-arg-uaf.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc -verify %s

#include "Inputs/system-header-simulator-for-malloc.h"

struct Obj {
int field;
};

void use(void *ptr);

void test_direct_param_uaf() {
int *p = (int *)malloc(sizeof(int));
free(p);
use(p); // expected-warning{{Use of memory after it is released}}
}

void test_struct_field_uaf() {
struct Obj *o = (struct Obj *)malloc(sizeof(struct Obj));
free(o);
use(&o->field); // expected-warning{{Use of memory after it is released}}
}

void test_no_warning_const_int() {
use((void *)0x1234); // no-warning
}

void test_no_warning_stack() {
int x = 42;
use(&x); // no-warning
}

void test_nested_alloc() {
struct Obj *o = (struct Obj *)malloc(sizeof(struct Obj));
use(o); // no-warning
free(o);
use(o); // expected-warning{{Use of memory after it is released}}
}

void test_nested_field() {
struct Obj *o = (struct Obj *)malloc(sizeof(struct Obj));
int *f = &o->field;
free(o);
use(f); // expected-warning{{Use of memory after it is released}}
}