Skip to content

[mlir][emitc] Simplify emitc::isSupportedFloatType (NFC) #152464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

[mlir][emitc] Simplify emitc::isSupportedFloatType (NFC) #152464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00761f
[mlir][emitc] Simplify emitc::isSupportedFloatType
EtoAndruwa Aug 7, 2025
865e41a
[mlir][emitc] Drop useless include
EtoAndruwa Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mlir/lib/Dialect/EmitC/IR/EmitC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,8 @@ bool mlir::emitc::isIntegerIndexOrOpaqueType(Type type) {
bool mlir::emitc::isSupportedFloatType(Type type) {
if (auto floatType = llvm::dyn_cast<FloatType>(type)) {
switch (floatType.getWidth()) {
case 16: {
if (llvm::isa<Float16Type, BFloat16Type>(type))
return true;
return false;
}
case 16:
return llvm::isa<Float16Type, BFloat16Type>(type);
case 32:
case 64:
return true;
Expand Down