Update .git-blame-ignore-revs for Pack/Unpack move #152469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds this large patch that merely moved Pack/Unpack Ops from the Tensor to Linalg dialects: * llvm#123902
rengolin
approved these changes
Aug 7, 2025
banach-space
added a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 8, 2025
…)" This reverts commit c43c1c0. Apologies for the noise — I misunderstood how `git blame --ignore-rev` works. It’s not suitable for large code-move changes and ends up making `git blame` more confusing rather than cleaner. From the Git documentation: > Lines that were changed or added by an ignored commit will be blamed > on the previous commit that changed that line or nearby lines. In this case, since so many new lines were added, skipping the commit causes `git blame` to attribute them to unrelated changes. I had expected Git to preserve the true origin of the lines while skipping the move itself — but that is not what happens. Therefore, I’m reverting this change. Ignoring the commit obscures blame history rather than improving it.
banach-space
added a commit
that referenced
this pull request
Aug 10, 2025
…#152661) This reverts commit c43c1c0. Apologies for the noise - I misunderstood how `git blame --ignore-rev` works. It’s not suitable for large code-move changes and ends up making `git blame` more confusing rather than cleaner. From the Git documentation: > Lines that were changed or added by an ignored commit will be blamed > on the previous commit that changed that line or nearby lines. In this case, since so many new lines were added, skipping the commit causes `git blame` to attribute them to unrelated changes. I had expected Git to preserve the true origin of the lines while skipping the move itself - but that is not what happens. Therefore, I’m reverting this change. Ignoring the commit obscures blame history rather than improving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this large patch that merely moved Pack/Unpack Ops from the Tensor
to Linalg dialects: