Skip to content

[lldb] Support the Python stable C API in PythonString::AsUTF8 #152599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,33 @@ Expected<llvm::StringRef> PythonString::AsUTF8() const {
if (!IsValid())
return nullDeref();

Py_ssize_t size;
const char *data;
// PyUnicode_AsUTF8AndSize caches the UTF-8 representation of the string in
// the Unicode object, which makes it more efficient and ties the lifetime of
// the data to the Python string. However, it was only added to the Stable API
// in Python 3.10. Older versions that want to use the Stable API must use
// PyUnicode_AsUTF8String in combination with ConstString.
#if defined(Py_LIMITED_API) && (Py_LIMITED_API < 0x030a0000)
PyObject *py_bytes = PyUnicode_AsUTF8String(m_py_obj);
if (!py_bytes)
return exception();
auto release_py_str =
llvm::make_scope_exit([py_bytes] { Py_DECREF(py_bytes); });
Py_ssize_t size = PyBytes_Size(py_bytes);
const char *str = PyBytes_AsString(py_bytes);

if (!str)
return exception();

data = PyUnicode_AsUTF8AndSize(m_py_obj, &size);
return ConstString(str, size).GetStringRef();
#else
Py_ssize_t size;
const char *str = PyUnicode_AsUTF8AndSize(m_py_obj, &size);

if (!data)
if (!str)
return exception();

return llvm::StringRef(data, size);
return llvm::StringRef(str, size);
#endif
}

size_t PythonString::GetSize() const {
Expand Down
Loading