[Dexter] add get_pc #152719
Merged
[Dexter] add get_pc #152719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2025
This was referenced Aug 8, 2025
SLTozer
reviewed
Aug 11, 2025
| """Get the current PC in frame at frame_idx depth. | ||
| frame_idx 0 is the current function. | ||
| """ | ||
| r = self.evaluate_expression("$pc", frame_idx) |
There was a problem hiding this comment.
Does $pc work for all supported debuggers?
There was a problem hiding this comment.
Define supported debugger - it works for our debugger and LLDB.
I suppose the failure mode could be more user friendly. An exception explaining the feature isn't supported by the debugger might be better than these asserts.
There was a problem hiding this comment.
LGTM with the exception instead of the asserts.
OCHyams
force-pushed
the
users/OCHyams/dexter-new-bps
branch
from
f537f45 to
7089cfd
Compare
OCHyams
force-pushed
the
users/OCHyams/get_pc
branch
from
47f3267 to
6fe4940
Compare
OCHyams
force-pushed
the
users/OCHyams/get_pc
branch
from
6fe4940 to
d35acc5
Compare
SLTozer
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.