Skip to content

Conversation

jprotze
Copy link
Collaborator

@jprotze jprotze commented Aug 8, 2025

Using hex format allows to better interpret IDs:
the first digits represent the thread number, the last digits represent the ID within a thread

The main change is in callback.h

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Aug 8, 2025
Copy link

github-actions bot commented Aug 8, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@jprotze jprotze marked this pull request as draft August 8, 2025 16:50
@jprotze jprotze requested review from hansangbae and mhalk August 13, 2025 14:50
@jprotze
Copy link
Collaborator Author

jprotze commented Aug 13, 2025

@kaloyan-ignatov will add another commit that guards the RUN and CHECK line blocks of all OMPT tests with clang-format on/off comments, so that the formatting check should pass in the future.

Copy link
Contributor

@hansangbae hansangbae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hex format allows to better interpret IDs: the first digits represent
the thread number, last digits represent the ID within a thread
specify clang-format off and on respectively around FileCheck lines
@jprotze jprotze marked this pull request as ready for review August 16, 2025 07:10
@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Aug 16, 2025
@jprotze jprotze merged commit 98dd188 into llvm:main Aug 18, 2025
12 checks passed
@jprotze jprotze deleted the ompt-hex-data branch August 18, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants