Skip to content

Add REQUIRES: riscv to test added in 151639 to skip the test when riscv is not built. #152858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025

Conversation

dyung
Copy link
Collaborator

@dyung dyung commented Aug 9, 2025

A test was added in #151639 which fails if the RISCV backend is not built, so add a REQUIRES: riscv to skip it when the backend is not present.

@dyung dyung requested a review from MaskRay August 9, 2025 13:58
@dyung dyung added the skip-precommit-approval PR for CI feedback, not intended for review label Aug 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 9, 2025

@llvm/pr-subscribers-backend-risc-v

Author: None (dyung)

Changes

A test was added in #151639 which fails if the RISCV backend is not built, so add a REQUIRES: riscv to skip it when the backend is not present.


Full diff: https://github.com/llvm/llvm-project/pull/152858.diff

1 Files Affected:

  • (modified) lld/test/ELF/riscv-relocatable-align.s (+1)
diff --git a/lld/test/ELF/riscv-relocatable-align.s b/lld/test/ELF/riscv-relocatable-align.s
index 9a782ed47850a..4ba932ce5f847 100644
--- a/lld/test/ELF/riscv-relocatable-align.s
+++ b/lld/test/ELF/riscv-relocatable-align.s
@@ -1,3 +1,4 @@
+# REQUIRES: riscv
 # RUN: rm -rf %t && split-file %s %t && cd %t
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax a.s -o ac.o
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax b.s -o bc.o

@llvmbot
Copy link
Member

llvmbot commented Aug 9, 2025

@llvm/pr-subscribers-lld-elf

Author: None (dyung)

Changes

A test was added in #151639 which fails if the RISCV backend is not built, so add a REQUIRES: riscv to skip it when the backend is not present.


Full diff: https://github.com/llvm/llvm-project/pull/152858.diff

1 Files Affected:

  • (modified) lld/test/ELF/riscv-relocatable-align.s (+1)
diff --git a/lld/test/ELF/riscv-relocatable-align.s b/lld/test/ELF/riscv-relocatable-align.s
index 9a782ed47850a..4ba932ce5f847 100644
--- a/lld/test/ELF/riscv-relocatable-align.s
+++ b/lld/test/ELF/riscv-relocatable-align.s
@@ -1,3 +1,4 @@
+# REQUIRES: riscv
 # RUN: rm -rf %t && split-file %s %t && cd %t
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax a.s -o ac.o
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax b.s -o bc.o

@llvmbot
Copy link
Member

llvmbot commented Aug 9, 2025

@llvm/pr-subscribers-lld

Author: None (dyung)

Changes

A test was added in #151639 which fails if the RISCV backend is not built, so add a REQUIRES: riscv to skip it when the backend is not present.


Full diff: https://github.com/llvm/llvm-project/pull/152858.diff

1 Files Affected:

  • (modified) lld/test/ELF/riscv-relocatable-align.s (+1)
diff --git a/lld/test/ELF/riscv-relocatable-align.s b/lld/test/ELF/riscv-relocatable-align.s
index 9a782ed47850a..4ba932ce5f847 100644
--- a/lld/test/ELF/riscv-relocatable-align.s
+++ b/lld/test/ELF/riscv-relocatable-align.s
@@ -1,3 +1,4 @@
+# REQUIRES: riscv
 # RUN: rm -rf %t && split-file %s %t && cd %t
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax a.s -o ac.o
 # RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax b.s -o bc.o

@dyung
Copy link
Collaborator Author

dyung commented Aug 9, 2025

@dyung dyung merged commit d1827f0 into llvm:main Aug 9, 2025
13 of 14 checks passed
@dyung dyung deleted the add-requires-151639 branch August 9, 2025 14:01
@MaskRay
Copy link
Member

MaskRay commented Aug 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:RISC-V lld:ELF lld skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants