Skip to content

[Clang] Remove redundant check for scoped enums in shift operators #152865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2025
Merged

[Clang] Remove redundant check for scoped enums in shift operators #152865

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc0a4c7
[Clang] Remove redundant check for scoped enums in shift operators
tinnamchoi Aug 9, 2025
c89d58e
Merge branch 'main' into tinnamchoi-remove-redundant-scoped-enum-check
Sirraide Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions clang/lib/Sema/SemaExpr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11747,12 +11747,6 @@ QualType Sema::CheckShiftOperands(ExprResult &LHS, ExprResult &RHS,
!RHSType->hasIntegerRepresentation())
return InvalidOperands(Loc, LHS, RHS);

// C++0x: Don't allow scoped enums. FIXME: Use something better than
// hasIntegerRepresentation() above instead of this.
if (isScopedEnumerationType(LHSType) ||
isScopedEnumerationType(RHSType)) {
return InvalidOperands(Loc, LHS, RHS);
}
DiagnoseBadShiftValues(*this, LHS, RHS, Loc, Opc, LHSType);

// "The type of the result is that of the promoted left operand."
Expand Down