[NFC][MC] Removed unused switch case in emitCATTR
#152907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch statement `switch (Rmode)` is in an if-block that checks if `Rmode != GOFF::ESD_RMODE_None` making the `case GOFF::ESD_RMODE_None:` unnecessary.
|
@llvm/pr-subscribers-mc Author: Abhishek Kaushik (abhishek-kaushik22) ChangesThe switch statement Full diff: https://github.com/llvm/llvm-project/pull/152907.diff 1 Files Affected:
diff --git a/llvm/lib/MC/MCAsmInfoGOFF.cpp b/llvm/lib/MC/MCAsmInfoGOFF.cpp
index 0a5d1927b1a22..d35020429e346 100644
--- a/llvm/lib/MC/MCAsmInfoGOFF.cpp
+++ b/llvm/lib/MC/MCAsmInfoGOFF.cpp
@@ -71,8 +71,6 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode,
case GOFF::ESD_RMODE_64:
OS << "64";
break;
- case GOFF::ESD_RMODE_None:
- break;
}
OS << ')';
}
|
MaskRay
approved these changes
Aug 10, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/11470 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/21299 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/17741 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/13996 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/15083 Here is the relevant piece of the build log for the reference |
abhishek-kaushik22
added a commit
that referenced
this pull request
Aug 10, 2025
abhishek-kaushik22
added a commit
that referenced
this pull request
Aug 10, 2025
|
Sorry, I was probably using a |
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 10, 2025
…`" (#152929) Reverts llvm/llvm-project#152907 This is causing some build failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch statement
switch (Rmode)is in an if-block that checks ifRmode != GOFF::ESD_RMODE_Nonemaking thecase GOFF::ESD_RMODE_None:unnecessary.