Skip to content

Revert "[NFC][MC] Removed unused switch case in emitCATTR" #152929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2025

Conversation

abhishek-kaushik22
Copy link
Contributor

Reverts #152907

This is causing some build failures.

@abhishek-kaushik22 abhishek-kaushik22 merged commit 61842ac into main Aug 10, 2025
6 of 9 checks passed
@llvmbot llvmbot added the mc Machine (object) code label Aug 10, 2025
@abhishek-kaushik22 abhishek-kaushik22 deleted the revert-152907-asminfogoff branch August 10, 2025 16:50
@llvmbot
Copy link
Member

llvmbot commented Aug 10, 2025

@llvm/pr-subscribers-mc

Author: Abhishek Kaushik (abhishek-kaushik22)

Changes

Reverts llvm/llvm-project#152907

This is causing some build failures.


Full diff: https://github.com/llvm/llvm-project/pull/152929.diff

1 Files Affected:

  • (modified) llvm/lib/MC/MCAsmInfoGOFF.cpp (+2)
diff --git a/llvm/lib/MC/MCAsmInfoGOFF.cpp b/llvm/lib/MC/MCAsmInfoGOFF.cpp
index d35020429e346..0a5d1927b1a22 100644
--- a/llvm/lib/MC/MCAsmInfoGOFF.cpp
+++ b/llvm/lib/MC/MCAsmInfoGOFF.cpp
@@ -71,6 +71,8 @@ static void emitCATTR(raw_ostream &OS, StringRef Name, GOFF::ESDRmode Rmode,
     case GOFF::ESD_RMODE_64:
       OS << "64";
       break;
+    case GOFF::ESD_RMODE_None:
+      break;
     }
     OS << ')';
   }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants