Skip to content

[clang] fix comment lexing of special command names #152943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 14, 2025
Merged

[clang] fix comment lexing of special command names #152943

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
475d513
[clang] fix comment parsing of special commands with non-alphanumeric…
Aug 7, 2025
961b588
Merge branch 'main' into issue-33296
mdenson Aug 10, 2025
824cf42
[clang] fix comment parsing of special commands with non-alphanumeric…
Aug 12, 2025
5f404a3
Merge branch 'main' into issue-33296
mdenson Aug 12, 2025
47a3c76
update release note
Aug 13, 2025
d0e5f0b
Merge branch 'main' into issue-33296
mdenson Aug 13, 2025
eae1f60
Merge branch 'main' into issue-33296
mdenson Aug 13, 2025
5bd3bd5
Merge branch 'main' into issue-33296
mdenson Aug 13, 2025
8679fcc
rerun pr checks
Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/AST/CommentLexer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ bool isCommandNameStartCharacter(char C) {
}

bool isCommandNameCharacter(char C) {
return isAlphanumeric(C);
return isAsciiIdentifierContinue(C, false);
}

const char *skipCommandName(const char *BufferPtr, const char *BufferEnd) {
Expand Down
6 changes: 6 additions & 0 deletions clang/test/AST/ast-dump-comment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,9 @@ void Test_TemplatedFunctionVariadic(int arg, ...);
// CHECK: ParamCommandComment{{.*}} [in] implicitly Param="..."
// CHECK-NEXT: ParagraphComment
// CHECK-NEXT: TextComment{{.*}} Text=" More arguments"

/// \thread_safe test for underscore in special command
int Test_UnderscoreInSpecialCommand;
// CHECK: VarDecl{{.*}}Test_UnderscoreInSpecialCommand 'int'
// CHECK: InlineCommandComment{{.*}} Name="thread_safe" RenderNormal
// CHECK-NEXT: TextComment{{.*}} Text=" test for underscore in special command"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs an empty line at the end of it.