Skip to content

[Clang] unrecognized html tag causing undesirable comment lexing #152944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2025
Merged

[Clang] unrecognized html tag causing undesirable comment lexing #152944

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cfd897
[clang] unrecognized html tag causing undesirable comment lexing. fix…
Aug 7, 2025
43b138d
[clang] unrecognized html tag causing undesirable comment lexing. fix…
Aug 7, 2025
cb7e5ab
Merge branch 'main' into issue-32680
mdenson Aug 14, 2025
70ece73
add tests for new tags
Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/include/clang/AST/CommentHTMLTags.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def Col : Tag<"col"> { let EndTagForbidden = 1; }
def Tr : Tag<"tr"> { let EndTagOptional = 1; }
def Th : Tag<"th"> { let EndTagOptional = 1; }
def Td : Tag<"td"> { let EndTagOptional = 1; }
def Summary : Tag<"summary">;

// Define a list of attributes that are not safe to pass through to HTML
// output if the input is untrusted.
Expand Down
9 changes: 9 additions & 0 deletions clang/test/AST/ast-dump-comment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,12 @@ void Test_TemplatedFunctionVariadic(int arg, ...);
// CHECK: ParamCommandComment{{.*}} [in] implicitly Param="..."
// CHECK-NEXT: ParagraphComment
// CHECK-NEXT: TextComment{{.*}} Text=" More arguments"

/// \param[out] Aaa <summary>Short summary</summary>
int Test_HTMLSummaryTag(int Aaa);
// CHECK: FunctionDecl{{.*}}Test_HTMLSummaryTag
// CHECK: ParamCommandComment{{.*}} [out] explicitly Param="Aaa"
// CHECK-NEXT: ParagraphComment
// CHECK: HTMLStartTagComment{{.*}} Name="summary"
// CHECK-NEXT: TextComment{{.*}} Text="Short summary"
// CHECK-NEXT: HTMLEndTagComment{{.*}} Name="summary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break