[flang][runtime] Handle NAN(...) in namelist input #153101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCChen
approved these changes
Aug 12, 2025
akuhlens
approved these changes
Aug 13, 2025
The various per-type functions for list-directed (including namelist)
input editing all call a common function to detect whether the
next token of input is the name of a namelist item. This check
simply determines whether this next token looks like an identifier
followed by '=', '(', or '%', and this fails when the next item of
input is a NAN with parenthesized stuff afterwards. Make the check
smarter so that it ensures that any upcoming possible identifier is
actually the name of an item in the namelist group. (And that's
tricky too when the group has an array item named "nan" and the
upcoming input is "nan("; see the newly-added unit test case.)
Fixes llvm#152538.
more
eugeneepshteyn
approved these changes
Aug 13, 2025
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Sep 7, 2025
…)" breaks 535.weather at runtime This reverts commit 925db84.
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Sep 7, 2025
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 4, 2025
The various per-type functions for list-directed (including namelist)
input editing all call a common function to detect whether the next
token of input is the name of a namelist item. This check simply
determines whether this next token looks like an identifier followed by
'=', '(', or '%', and this fails when the next item of input is a NAN
with parenthesized stuff afterwards. Make the check smarter so that it
ensures that any upcoming possible identifier is actually the name of an
item in the namelist group. (And that's tricky too when the group has an
array item named "nan" and the upcoming input is "nan("; see the
newly-added unit test case.)
Fixes llvm#152538.
more
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various per-type functions for list-directed (including namelist) input editing all call a common function to detect whether the next token of input is the name of a namelist item. This check simply determines whether this next token looks like an identifier followed by '=', '(', or '%', and this fails when the next item of input is a NAN with parenthesized stuff afterwards. Make the check smarter so that it ensures that any upcoming possible identifier is actually the name of an item in the namelist group. (And that's tricky too when the group has an array item named "nan" and the upcoming input is "nan("; see the newly-added unit test case.)
Fixes #152538.
more