[CAS] Fix a link error introduced by CAS

[shiltian]

It is missing link components which can cause link error when building as a shared library.

[shiltian]

• [CAS] Fix a link error introduced by CAS #153235 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shiltian]

This is introduced by #114096.

[cachemeifyoucan]

Thanks!

[jplehr]

@shiltian can this be merged now?
Thanks!

[llvm-ci]

LLVM Buildbot has detected a new failure on builder flang-arm64-windows-msvc running on linaro-armv8-windows-msvc-01 while building llvm at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/207/builds/5167

Here is the relevant piece of the build log for the reference

Step 5 (build-unified-tree) failure: build (failure)
...
110.274 [3153/10/4251] Building CXX object tools\flang\lib\Support\CMakeFiles\FortranSupport.dir\Version.cpp.obj
111.467 [3152/10/4252] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\ASTMerge.cpp.obj
111.514 [3151/10/4253] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\ASTUnit.cpp.obj
111.629 [3150/10/4254] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\ChainedIncludesSource.cpp.obj
111.716 [3149/10/4255] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\CompilerInstance.cpp.obj
113.855 [3148/10/4256] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\FrontendOptions.cpp.obj
114.711 [3147/10/4257] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\DiagnosticRenderer.cpp.obj
115.539 [3146/10/4258] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\DependencyGraph.cpp.obj
117.935 [3145/10/4259] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\HeaderIncludeGen.cpp.obj
119.059 [3144/10/4260] Building CXX object tools\flang\lib\Support\CMakeFiles\FortranSupport.dir\OpenMP-utils.cpp.obj
FAILED: tools/flang/lib/Support/CMakeFiles/FortranSupport.dir/OpenMP-utils.cpp.obj 
C:\Users\tcwg\scoop\shims\ccache.exe C:\Users\tcwg\scoop\apps\llvm-arm64\current\bin\clang-cl.exe  /nologo -TP -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\flang\lib\Support -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\lib\Support -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\flang\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\llvm\include -imsvcC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\..\mlir\include -imsvcC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\mlir\include -imsvcC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\clang\include -imsvcC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\llvm\..\clang\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported /O2 /Ob2  -std:c++17 -MD  /EHs-c- /GR- -UNDEBUG /showIncludes /Fotools\flang\lib\Support\CMakeFiles\FortranSupport.dir\OpenMP-utils.cpp.obj /Fdtools\flang\lib\Support\CMakeFiles\FortranSupport.dir\FortranSupport.pdb -c -- C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\lib\Support\OpenMP-utils.cpp
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\lib\Support\OpenMP-utils.cpp:9:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\include\flang/Support/OpenMP-utils.h:12:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\include\flang/Optimizer/Builder/DirectivesCommon.h:25:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\include\flang/Optimizer/HLFIR/HLFIROps.h:17:
C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\flang\include\flang/Optimizer/HLFIR/HLFIRDialect.h(28,10): fatal error: 'flang/Optimizer/HLFIR/HLFIRDialect.h.inc' file not found
   28 | #include "flang/Optimizer/HLFIR/HLFIRDialect.h.inc"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
119.102 [3144/9/4261] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\LogDiagnosticPrinter.cpp.obj
119.848 [3144/8/4262] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\CreateInvocationFromCommandLine.cpp.obj
120.618 [3144/7/4263] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\LayoutOverrideSource.cpp.obj
120.822 [3144/6/4264] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\DependencyFile.cpp.obj
124.912 [3144/5/4265] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\InitPreprocessor.cpp.obj
125.875 [3144/4/4266] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\FrontendAction.cpp.obj
126.843 [3144/3/4267] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\ModuleDependencyCollector.cpp.obj
127.959 [3144/2/4268] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\FrontendActions.cpp.obj
133.875 [3144/1/4269] Building CXX object tools\clang\lib\Frontend\CMakeFiles\obj.clangFrontend.dir\CompilerInvocation.cpp.obj
ninja: build stopped: subcommand failed.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder lldb-aarch64-ubuntu running on linaro-lldb-aarch64-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/22493

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: lang/c/local_variables/TestLocalVariables.py (755 of 2305)
PASS: lldb-api :: lang/c/offsetof/TestOffsetof.py (756 of 2305)
XFAIL: lldb-api :: lang/c/modules/TestCModules.py (757 of 2305)
PASS: lldb-api :: lang/c/non-mangled/TestCNonMangled.py (758 of 2305)
PASS: lldb-api :: lang/c/record_decl_in_expr/TestRecordDeclInExpr.py (759 of 2305)
PASS: lldb-api :: lang/c/parray_vrs_char_array/TestParrayVrsCharArrayChild.py (760 of 2305)
PASS: lldb-api :: lang/c/sizeof/TestCSizeof.py (761 of 2305)
PASS: lldb-api :: lang/c/register_variables/TestRegisterVariables.py (762 of 2305)
PASS: lldb-api :: lang/c/set_values/TestSetValues.py (763 of 2305)
UNRESOLVED: lldb-api :: functionalities/statusline/TestStatusline.py (764 of 2305)
******************** TEST 'lldb-api :: functionalities/statusline/TestStatusline.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --cmake-build-type Release /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/statusline -p TestStatusline.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 22.0.0git (https://github.com/llvm/llvm-project.git revision cd1c58ae5a9855470fa2cafd357793832b468a8a)
  clang revision cd1c58ae5a9855470fa2cafd357793832b468a8a
  llvm revision cd1c58ae5a9855470fa2cafd357793832b468a8a
Skipping the following test categories: ['libc++', 'msvcstl', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test (TestStatusline.TestStatusline)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_deadlock (TestStatusline.TestStatusline)
lldb-server exiting...
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_modulelist_deadlock (TestStatusline.TestStatusline)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_no_color (TestStatusline.TestStatusline)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_no_target (TestStatusline.TestStatusline)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_resize (TestStatusline.TestStatusline)
======================================================================
ERROR: test_modulelist_deadlock (TestStatusline.TestStatusline)
   Regression test for a deadlock that occurs when the status line is enabled before connecting
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/statusline/TestStatusline.py", line 199, in test_modulelist_deadlock
    self.expect(
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbpexpect.py", line 95, in expect
    self.expect_prompt()
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/lldbpexpect.py", line 19, in expect_prompt
    self.child.expect_exact(self.PROMPT)
  File "/usr/local/lib/python3.10/dist-packages/pexpect/spawnbase.py", line 432, in expect_exact
    return exp.expect_loop(timeout)
  File "/usr/local/lib/python3.10/dist-packages/pexpect/expect.py", line 179, in expect_loop
    return self.eof(e)