Skip to content

Conversation

@kparzysz
Copy link
Contributor

No description provided.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Aug 13, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 13, 2025

@llvm/pr-subscribers-flang-semantics

Author: Krzysztof Parzyszek (kparzysz)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153409.diff

1 Files Affected:

  • (modified) flang/lib/Semantics/check-omp-atomic.cpp (+3-3)
diff --git a/flang/lib/Semantics/check-omp-atomic.cpp b/flang/lib/Semantics/check-omp-atomic.cpp
index f98a00070f742..2e16d42a2a99a 100644
--- a/flang/lib/Semantics/check-omp-atomic.cpp
+++ b/flang/lib/Semantics/check-omp-atomic.cpp
@@ -718,7 +718,7 @@ OmpStructureChecker::CheckUpdateCapture(
 void OmpStructureChecker::CheckAtomicCaptureAssignment(
     const evaluate::Assignment &capture, const SomeExpr &atom,
     parser::CharBlock source) {
-  auto [lsrc, rsrc]{SplitAssignmentSource(source)};
+  auto [_, rsrc]{SplitAssignmentSource(source)};
   const SomeExpr &cap{capture.lhs};
 
   if (!IsVarOrFunctionRef(atom)) {
@@ -734,7 +734,7 @@ void OmpStructureChecker::CheckAtomicCaptureAssignment(
 
 void OmpStructureChecker::CheckAtomicReadAssignment(
     const evaluate::Assignment &read, parser::CharBlock source) {
-  auto [lsrc, rsrc]{SplitAssignmentSource(source)};
+  auto [_, rsrc]{SplitAssignmentSource(source)};
 
   if (auto maybe{GetConvertInput(read.rhs)}) {
     const SomeExpr &atom{*maybe};
@@ -820,7 +820,7 @@ OmpStructureChecker::CheckAtomicUpdateAssignment(
 std::pair<bool, bool> OmpStructureChecker::CheckAtomicUpdateAssignmentRhs(
     const SomeExpr &atom, const SomeExpr &rhs, parser::CharBlock source,
     bool suppressDiagnostics) {
-  auto [lsrc, rsrc]{SplitAssignmentSource(source)};
+  auto [_, rsrc]{SplitAssignmentSource(source)};
 
   std::pair<operation::Operator, std::vector<SomeExpr>> top{
       operation::Operator::Unknown, {}};

@kparzysz kparzysz merged commit 6b20b16 into llvm:main Aug 13, 2025
12 checks passed
@kparzysz kparzysz deleted the users/kparzysz/fix-unused-variable branch August 13, 2025 13:59
klausler pushed a commit to klausler/llvm-project that referenced this pull request Aug 13, 2025
This reverts commit 6b20b16.

This patch depends on PR153098 which is the one being reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:semantics flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants