-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[NFC][OpenMP] Claim OMPT device tracing #153411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jplehr
merged 1 commit into
llvm:main
from
jplehr:nfc/claim-ompt-device-tracing-support
Aug 13, 2025
Merged
[NFC][OpenMP] Claim OMPT device tracing #153411
jplehr
merged 1 commit into
llvm:main
from
jplehr:nfc/claim-ompt-device-tracing-support
Aug 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Jan Patrick Lehr (jplehr) ChangesPlanning to start upstreaming our implementation soon. Full diff: https://github.com/llvm/llvm-project/pull/153411.diff 1 Files Affected:
diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst
index 1f502db535872..13c26ef10150b 100644
--- a/clang/docs/OpenMPSupport.rst
+++ b/clang/docs/OpenMPSupport.rst
@@ -338,7 +338,7 @@ implementation.
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| OMPT | new 'emi' callbacks for external monitoring interfaces | :good:`done` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| OMPT | device tracing interface | :none:`unclaimed` | |
+| OMPT | device tracing interface | :none:`in progress` | jplehr |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| task | 'strict' modifier for taskloop construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
|
mjklemm
approved these changes
Aug 13, 2025
Contributor
mjklemm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Author
|
Can someone else with better rst skills please look at that table? |
mjklemm
requested changes
Aug 13, 2025
mjklemm
reviewed
Aug 13, 2025
mjklemm
approved these changes
Aug 13, 2025
Planning to start upstreaming our implementation soon.
c587c5d to
5249894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to start upstreaming our implementation soon.