[MLIR][XeGPU] Distribute load_nd/store_nd/prefetch_nd with offsets from Wg to Sg #153432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencha3
approved these changes
Aug 14, 2025
Jianhui-Li
reviewed
Aug 15, 2025
Jianhui-Li
reviewed
Aug 15, 2025
Jianhui-Li
reviewed
Aug 15, 2025
can you please also add a link to the corresponding PR with create_nd |
Jianhui-Li
reviewed
Aug 16, 2025
Jianhui-Li
reviewed
Aug 16, 2025
| SmallVector<OpFoldResult> wgOffsets = getWgOffsets(op, rewriter); | ||
|
|
||
| // Calculate the global offsets | ||
| auto globalOffsets = |
There was a problem hiding this comment.
how about call it allOffsets instead of globalOffsets? Not sure what global means here.
Jianhui-Li
approved these changes
Aug 16, 2025
adam-smnk
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pattern to distribute the load/store/prefetch nd ops with offsets from workgroup to subgroup IR. This PR is part of the transition to move offsets from create_nd to load/store/prefetch nd ops.
Create_nd PR : #152351