Skip to content

[clang-repl][AIX][zOS] Disable clang/test/Interpreter tests on AIX and zOS (NFC) #153587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2025
Merged

[clang-repl][AIX][zOS] Disable clang/test/Interpreter tests on AIX and zOS (NFC) #153587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7111f28
[clang-repl][AIX][zOS] Disable clang/test/Interpreter tests on AIX an…
kkwli Aug 12, 2025
df15ed4
check config.available_features instead
kkwli Aug 15, 2025
1f22da0
Merge branch 'main' into disable-interpreter-tests
kkwli Aug 15, 2025
f1dae59
Merge branch 'main' into disable-interpreter-tests
kkwli Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clang/test/Interpreter/assignment-with-implicit-ctor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
//
// RUN: cat %s | clang-repl | FileCheck %s
// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/bad_percent_command.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl 2>&1 | FileCheck %s
%foobar
// CHECK: Invalid % command "%foobar", use "%help" to list commands
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/code-undo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl | FileCheck %s
extern "C" int printf(const char *, ...);
int x1 = 0;
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/const.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// UNSUPPORTED: system-aix, system-zos
// see https://github.com/llvm/llvm-project/issues/68092
// XFAIL: host={{.*}}-windows-msvc

Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/cxx20-modules.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit, x86_64-linux
// UNSUPPORTED: system-aix
//
// RUN: rm -rf %t
// RUN: mkdir -p %t
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/dynamic-library-bad-args.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl 2>&1 | FileCheck %s
%lib
// CHECK: %lib expects 1 argument: the path to a dynamic library
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/execute-stmts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl -Xcc -Xclang -Xcc -verify | FileCheck %s
// RUN: %clang_cc1 -verify -fincremental-extensions -emit-llvm -o - %s \
// RUN: | FileCheck --check-prefix=CODEGEN-CHECK %s
Expand Down
2 changes: 1 addition & 1 deletion clang/test/Interpreter/execute-weak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// UNSUPPORTED: system-aix, system-windows
// UNSUPPORTED: system-windows
// RUN: cat %s | clang-repl | FileCheck %s

extern "C" int printf(const char *, ...);
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/execute.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix

// RUN: cat %s | clang-repl -Xcc -xc -Xcc -Xclang -Xcc -verify | FileCheck %s
// RUN: cat %s | clang-repl -Xcc -xc -Xcc -O2 -Xcc -Xclang -Xcc -verify| FileCheck %s
Expand Down
2 changes: 0 additions & 2 deletions clang/test/Interpreter/execute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// UNSUPPORTED: system-aix

// clang-format off
// RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,...);' \
// RUN: 'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/fail.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// clang-repl can be called from the prompt in non-interactive mode as a
// calculator in shell scripts, for example. In that case if there is an error
// we should set the exit code as failure.
Expand Down
3 changes: 1 addition & 2 deletions clang/test/Interpreter/global-dtor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// clang-format off
// UNSUPPORTED: system-aix
//
// Tests that a global destructor is ran on platforms with gnu exception support.
//
Expand All @@ -10,4 +9,4 @@ extern "C" int printf(const char *, ...);
struct D { float f = 1.0; D *m = nullptr; D(){} ~D() { printf("D[f=%f, m=0x%llx]\n", f, reinterpret_cast<unsigned long long>(m)); }} d;
// CHECK: D[f=1.000000, m=0x0]

%quit
%quit
1 change: 0 additions & 1 deletion clang/test/Interpreter/help.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl | FileCheck %s
%help
// CHECK: %help list clang-repl %commands
Expand Down
2 changes: 0 additions & 2 deletions clang/test/Interpreter/incremental-mode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// UNSUPPORTED: system-aix
//
// RUN: clang-repl -Xcc -E
// RUN: clang-repl -Xcc -emit-llvm
// RUN: clang-repl -Xcc -xc
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/inline-asm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit, x86_64-linux
// UNSUPPORTED: system-aix
//
// RUN: rm -rf %t
// RUN: mkdir -p %t
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/inline-virtual.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
//
// This test is flaky with ASan: https://github.com/llvm/llvm-project/issues/135401
// UNSUPPORTED: asan
Expand Down
3 changes: 1 addition & 2 deletions clang/test/Interpreter/lambda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl | FileCheck %s
// At -O2, somehow "x = 42" appears first when piped into FileCheck,
// see https://github.com/llvm/llvm-project/issues/143547.
Expand Down Expand Up @@ -27,4 +26,4 @@ auto capture = [&]() { return x * 2; };
printf("x = %d\n", x);
// CHECK: x = 42

%quit
%quit
5 changes: 4 additions & 1 deletion clang/test/Interpreter/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
if "host-supports-jit" not in config.available_features:
import sys

# clang-repl is not supported on AIX and zOS
if "host-supports-jit" not in config.available_features or sys.platform == "aix" or sys.platform == "zos":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it amounts to the same thing, but since we have lit features for these things already, we should use them. For instance file elsewhere does:

if "system-aix" in config.available_features:
    config.unsupported = True

Though that is in llvm and the feature is added by llvm/utils/lit/lit/llvm/config.py. You might have to add the zOS feature to clang's equivalent file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it amounts to the same thing, but since we have lit features for these things already, we should use them. For instance file elsewhere does:

if "system-aix" in config.available_features:
    config.unsupported = True

Though that is in llvm and the feature is added by llvm/utils/lit/lit/llvm/config.py. You might have to add the zOS feature to clang's equivalent file.

Thanks @DavidSpickett. I update the patch with your suggestions.

config.unsupported = True
1 change: 0 additions & 1 deletion clang/test/Interpreter/multiline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl -Xcc -Xclang -Xcc -verify | FileCheck %s

// expected-no-diagnostics
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/pretty-print.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: host-supports-jit
// UNSUPPORTED: system-aix
// RUN: cat %s | clang-repl -Xcc -xc | FileCheck %s
// RUN: cat %s | clang-repl -Xcc -std=c++11 | FileCheck %s

Expand Down
2 changes: 1 addition & 1 deletion clang/test/Interpreter/pretty-print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,...);' \
// RUN: 'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
// The test is flaky with asan https://github.com/llvm/llvm-project/pull/148701.
// UNSUPPORTED: system-aix, asan
// UNSUPPORTED: asan
// CHECK-DRIVER: i = 10
// RUN: cat %s | clang-repl -Xcc -std=c++11 -Xcc -fno-delayed-template-parsing | FileCheck %s
extern "C" int printf(const char*,...);
Expand Down
1 change: 0 additions & 1 deletion clang/test/Interpreter/simple-exception.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// clang-format off
// UNSUPPORTED: system-aix
// XFAIL for arm, or running on Windows.
// XFAIL: target=arm-{{.*}}, target=armv{{.*}}, system-windows, system-cygwin
// RUN: cat %s | clang-repl | FileCheck %s
Expand Down