[Clang][Sema] Add nullptr check in IsFunctionConversion

[shafik]

Static analysis flagged this code b/c ToFPT could be nullptr but we were not checking it even though in the previous if statement we did. It looks like this was a mistaken refactor from:

#135836

In the older code ToFPT was set using a cast which would have asserted but no longer in the new code.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Shafik Yaghmour (shafik)

Changes

Static analysis flagged this code b/c ToFPT could be nullptr but we were not checking it even though in the previous if statement we did. It looks like this was a mistaken refactor from:

#135836

In the older code ToFPT was set using a cast which would have asserted but no longer in the new code.

---

Full diff: https://github.com/llvm/llvm-project/pull/153710.diff

1 Files Affected:

• (modified) clang/lib/Sema/SemaOverload.cpp (+1-1)

diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index ac64dd5c9c41f..7c4405b414c47 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -1979,7 +1979,7 @@ bool Sema::IsFunctionConversion(QualType FromType, QualType ToType,
   }
 
   // Drop 'noexcept' if not present in target type.
-  if (FromFPT) {
+  if (FromFPT && ToFPT) {
     if (FromFPT->isNothrow() && !ToFPT->isNothrow()) {
       FromFn = cast<FunctionType>(
           Context.getFunctionTypeWithExceptionSpec(QualType(FromFPT, 0),

[Sirraide]

Yeah, I can’t see how that if statement wouldn’t just explode if ToFPT ended up being null, so this makes sense.