Skip to content

[libc] Remove hardcoded sizeof in __barrier_type.h #153718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 21, 2025
Merged

[libc] Remove hardcoded sizeof in __barrier_type.h #153718

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08a3fee
Remove hardcoded sizeof
mikhailramalho Aug 15, 2025
0d1d202
Fix test case
mikhailramalho Aug 15, 2025
0da48fd
Changed static_assert
mikhailramalho Aug 15, 2025
bad2a60
Merge remote-tracking branch 'fork/libc-fixmbrtowc' into libc-barrier…
mikhailramalho Aug 15, 2025
5844bf7
Update comment
mikhailramalho Aug 20, 2025
ae0011c
Merge branch 'main' into libc-barrier-type-fix
mikhailramalho Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions libc/src/__support/threads/linux/barrier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,19 @@ class Barrier {
int wait();
};

static_assert(
sizeof(Barrier) == sizeof(pthread_barrier_t),
"The public pthread_barrier_t type cannot accommodate the internal "
"barrier type.");

static_assert(alignof(Barrier) == alignof(pthread_barrier_t),
"The public pthread_barrier_t type has a different alignment "
"than the internal barrier type.");
static_assert(sizeof(Barrier) <= sizeof(pthread_barrier_t),
"The public pthread_barrier_t type cannot accommodate the "
"internal barrier type.");

static_assert(alignof(Barrier) <= alignof(pthread_barrier_t),
"The public pthread_barrier_t type has insufficient alignment "
"for the internal barrier type.");

static_assert(sizeof(CndVar) <= 24,
"CndVar size exceeds the size in __barrier_type.h");

static_assert(sizeof(Mutex) <= 24,
"Mutex size exceeds the size in __barrier_type.h");

} // namespace LIBC_NAMESPACE_DECL

Expand Down
Loading