Skip to content

Conversation

@MaskRay
Copy link
Member

@MaskRay MaskRay commented Aug 15, 2025

As a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR #149935.

This commit introduces the llvm:mc label to cover the generic MC
interface, excluding target-specific MCTargetDesc files.

  • Rename the mc label to llvm:mc for consistency with other LLVM subdirectory labels.
  • Exclude llvm/test/MC from the label scope, as it contains many target-specific directories.

Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc
to "pr-subscribers-llvm:mc", similar to pr-subscribers-llvm:ir

@MaskRay MaskRay requested review from lenary and tstellar August 15, 2025 03:55
As a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR llvm#149935.

This commit introduces the `llvm:mc` label to cover the generic MC
interface, excluding target-specific MCTargetDesc files.

- Rename the `mc` label to `llvm:mc` for consistency with other LLVM subdirectory labels.
- Exclude `llvm/test/MC` from the label scope, as it contains many target-specific directories.

Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc
to "pr-subscribers-llvm:mc", similar to pr-subscribers-llvm:ir
@MaskRay
Copy link
Member Author

MaskRay commented Aug 15, 2025

Requests to admin:)

Comment on lines 622 to 624
Copy link
Member

@lenary lenary Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to change this recently too, sorry I didn't get around to it before you did. I agree with your other proposed changes to the labels for PRs/Issues.

Please add:

  • llvm/include/llvm/MC/**
  • llvm/tools/llvm-mc/**

I agree on skipping llvm/unittests/MC for the same reasons as excluding thellvm/tests/MC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Done

@MaskRay MaskRay requested a review from lenary August 15, 2025 16:36
@MaskRay MaskRay added the llvm:mc Machine (object) code label Aug 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2025

@llvm/pr-subscribers-mc

Author: Fangrui Song (MaskRay)

Changes

As a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR #149935.

This commit introduces the llvm:mc label to cover the generic MC
interface, excluding target-specific MCTargetDesc files.

  • Rename the mc label to llvm:mc for consistency with other LLVM subdirectory labels.
  • Exclude llvm/test/MC from the label scope, as it contains many target-specific directories.

Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc
to "pr-subscribers-llvm:mc", similar to pr-subscribers-llvm:ir


Full diff: https://github.com/llvm/llvm-project/pull/153737.diff

1 Files Affected:

  • (modified) .github/new-prs-labeler.yml (+6-3)
diff --git a/.github/new-prs-labeler.yml b/.github/new-prs-labeler.yml
index 8e0fa8d42d735..837a1bfa5b627 100644
--- a/.github/new-prs-labeler.yml
+++ b/.github/new-prs-labeler.yml
@@ -90,9 +90,6 @@ LTO:
   - llvm/lib/Transforms/*/FunctionImport*
   - llvm/tools/gold/**
 
-mc:
-  - llvm/*/MC/**
-
 clang:driver:
   - clang/*/Driver/**
 
@@ -621,6 +618,12 @@ llvm:adt:
 llvm:support:
   - llvm/**/Support/**
 
+# Skip llvm/test/MC, which includes target-specific directories
+llvm:mc:
+  - llvm/include/llvm/MC/**
+  - llvm/lib/MC/**
+  - llvm/tools/llvm-mc/**
+
 llvm:transforms:
   - llvm/lib/Transforms/**
   - llvm/include/llvm/Transforms/**

@MaskRay
Copy link
Member Author

MaskRay commented Aug 15, 2025

Requests to admin:)

I renamed mc to llvm:mc, but the other tasks can only be performed by an admin. @tstellar

@MaskRay MaskRay merged commit e342dcd into llvm:main Aug 16, 2025
9 checks passed
@MaskRay MaskRay deleted the mc-label branch August 16, 2025 01:23
@MaskRay
Copy link
Member Author

MaskRay commented Aug 19, 2025

Requests to admin:)

I renamed mc to llvm:mc, but the other tasks can only be performed by an admin. @tstellar

Ping admin @tstellar @asl :)

@MaskRay
Copy link
Member Author

MaskRay commented Aug 30, 2025

Ping admin @tstellar @asl :)

@tstellar tstellar added llvm:mc Machine (object) code and removed llvm:mc Machine (object) code labels Aug 30, 2025
@tstellar
Copy link
Collaborator

Teams created. @MaskRay Do you want me to add you to both teams?

@lenary
Copy link
Member

lenary commented Aug 31, 2025

I don't see the requested teams changes showing up in github.com/orgs/llvm/teams - so I'm confused. I do see the new issue-subscribers team, but the other two changes don't seem to have happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:mc Machine (object) code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants