-
Notifications
You must be signed in to change notification settings - Fork 15.2k
github: Add llvm:mc label for generic MC interface #153737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR llvm#149935. This commit introduces the `llvm:mc` label to cover the generic MC interface, excluding target-specific MCTargetDesc files. - Rename the `mc` label to `llvm:mc` for consistency with other LLVM subdirectory labels. - Exclude `llvm/test/MC` from the label scope, as it contains many target-specific directories. Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc to "pr-subscribers-llvm:mc", similar to pr-subscribers-llvm:ir
|
Requests to admin:)
|
.github/new-prs-labeler.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to change this recently too, sorry I didn't get around to it before you did. I agree with your other proposed changes to the labels for PRs/Issues.
Please add:
llvm/include/llvm/MC/**llvm/tools/llvm-mc/**
I agree on skipping llvm/unittests/MC for the same reasons as excluding thellvm/tests/MC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! Done
|
@llvm/pr-subscribers-mc Author: Fangrui Song (MaskRay) ChangesAs a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR #149935. This commit introduces the
Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc Full diff: https://github.com/llvm/llvm-project/pull/153737.diff 1 Files Affected:
diff --git a/.github/new-prs-labeler.yml b/.github/new-prs-labeler.yml
index 8e0fa8d42d735..837a1bfa5b627 100644
--- a/.github/new-prs-labeler.yml
+++ b/.github/new-prs-labeler.yml
@@ -90,9 +90,6 @@ LTO:
- llvm/lib/Transforms/*/FunctionImport*
- llvm/tools/gold/**
-mc:
- - llvm/*/MC/**
-
clang:driver:
- clang/*/Driver/**
@@ -621,6 +618,12 @@ llvm:adt:
llvm:support:
- llvm/**/Support/**
+# Skip llvm/test/MC, which includes target-specific directories
+llvm:mc:
+ - llvm/include/llvm/MC/**
+ - llvm/lib/MC/**
+ - llvm/tools/llvm-mc/**
+
llvm:transforms:
- llvm/lib/Transforms/**
- llvm/include/llvm/Transforms/**
|
I renamed |
|
|
|
Teams created. @MaskRay Do you want me to add you to both teams? |
|
I don't see the requested teams changes showing up in github.com/orgs/llvm/teams - so I'm confused. I do see the new issue-subscribers team, but the other two changes don't seem to have happened? |
As a member of github.com/orgs/llvm/teams/pr-subscribers-llvm-mc , I was not notified about PR #149935.
This commit introduces the
llvm:mclabel to cover the generic MCinterface, excluding target-specific MCTargetDesc files.
mclabel tollvm:mcfor consistency with other LLVM subdirectory labels.llvm/test/MCfrom the label scope, as it contains many target-specific directories.Admin: please change the name of https://github.com/orgs/llvm/teams/pr-subscribers-llvm-mc
to "pr-subscribers-llvm:mc", similar to pr-subscribers-llvm:ir