[CI] Add Basic Bazel Checks #153740
Merged
[CI] Add Basic Bazel Checks #153740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomanaiden154
force-pushed
the
basic-bazel-checks
branch
6 times, most recently
from
f89e04e to
266c477
Compare
Having basic checks (like running buildifier) on the upstream bazel files would be helpful for contributors maintaining the bazel build. Add basic checks (currently just buildifier) to a workflow that runs whenever the bazel build files change.
boomanaiden154
force-pushed
the
basic-bazel-checks
branch
from
266c477 to
45a06d3
Compare
|
https://github.com/llvm/llvm-project/actions/runs/16983068481/job/48146846926?pr=153740 caught some issues fixed in 4f15deb, so it appears like this does work. |
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesHaving basic checks (like running buildifier) on the upstream bazel files would be helpful for contributors maintaining the bazel build. Add basic checks (currently just buildifier) to a workflow that runs whenever the bazel build files change. Full diff: https://github.com/llvm/llvm-project/pull/153740.diff 1 Files Affected:
diff --git a/.github/workflows/bazel-checks.yml b/.github/workflows/bazel-checks.yml
new file mode 100644
index 0000000000000..65d51649dd9e7
--- /dev/null
+++ b/.github/workflows/bazel-checks.yml
@@ -0,0 +1,32 @@
+name: Bazel Checks
+
+permissions:
+ contents: read
+
+on:
+ push:
+ paths:
+ - '.github/workflows/bazel-checks.yml'
+ - 'utils/bazel/**'
+ branches:
+ - main
+ pull_request:
+ paths:
+ - '.github/workflows/bazel-checks.yml'
+ - 'utils/bazel/**'
+
+jobs:
+ buildifier:
+ name: "Buildifier"
+ runs-on: ubuntu-24.04
+ if: github.repository == 'llvm/llvm-project'
+ steps:
+ - name: Fetch LLVM sources
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+ - name: Setup Buildifier
+ run: |
+ sudo curl -L https://github.com/bazelbuild/buildtools/releases/download/v8.2.1/buildifier-linux-amd64 -o /usr/bin/buildifier
+ sudo chmod +x /usr/bin/buildifier
+ - name: Run Buildifier
+ run: |
+ buildifier --mode=check $(find ./utils/bazel -name *BUILD*)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having basic checks (like running buildifier) on the upstream bazel files would be helpful for contributors maintaining the bazel build. Add basic checks (currently just buildifier) to a workflow that runs whenever the bazel build files change.