Skip to content

Conversation

H-G-Hristov
Copy link
Contributor

@H-G-Hristov H-G-Hristov commented Aug 15, 2025

Already implemented in LLVM18: 695138c

For details see: #105045 (comment)

Closes #105045

@H-G-Hristov H-G-Hristov requested a review from a team as a code owner August 15, 2025 07:21
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 15, 2025
@H-G-Hristov H-G-Hristov changed the title [libc++][jthread] LWG3788: jthread::operator=(jthread&&) postconditions are unimplementable under self-assignment [libc++][jthread] LWG3788: jthread::operator=(jthread&&) postconditions are unimplementable under self-assignment Aug 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2025

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

Already implemented in LLVM18: 695138c

For details see: #105045 (comment)

Closes #105045


Full diff: https://github.com/llvm/llvm-project/pull/153758.diff

1 Files Affected:

  • (modified) libcxx/docs/Status/Cxx23Issues.csv (+1-1)
diff --git a/libcxx/docs/Status/Cxx23Issues.csv b/libcxx/docs/Status/Cxx23Issues.csv
index 189f8452e0678..0103d6319f164 100644
--- a/libcxx/docs/Status/Cxx23Issues.csv
+++ b/libcxx/docs/Status/Cxx23Issues.csv
@@ -230,7 +230,7 @@
 "`LWG3782 <https://wg21.link/LWG3782>`__","Should ``<math.h>`` declare ``::lerp``?","2022-11 (Kona)","|Complete|","17",""
 "`LWG3784 <https://wg21.link/LWG3784>`__","std.compat should not provide ``::byte`` and its friends","2022-11 (Kona)","|Complete|","19",""
 "`LWG3785 <https://wg21.link/LWG3785>`__","``ranges::to`` is over-constrained on the destination type being a range","2022-11 (Kona)","","",""
-"`LWG3788 <https://wg21.link/LWG3788>`__","``jthread::operator=(jthread&&)`` postconditions are unimplementable under self-assignment","2022-11 (Kona)","","",""
+"`LWG3788 <https://wg21.link/LWG3788>`__","``jthread::operator=(jthread&&)`` postconditions are unimplementable under self-assignment","2022-11 (Kona)","|Complete|","18",""
 "`LWG3792 <https://wg21.link/LWG3792>`__","``__cpp_lib_constexpr_algorithms`` should also be defined in ``<utility>``","2022-11 (Kona)","|Complete|","16",""
 "`LWG3795 <https://wg21.link/LWG3795>`__","Self-move-assignment of ``std::future`` and ``std::shared_future`` have unimplementable postconditions","2022-11 (Kona)","","",""
 "`LWG3796 <https://wg21.link/LWG3796>`__","``movable-box`` as member should use ``default-initialization`` instead of ``copy-initialization``","2022-11 (Kona)","","",""

@H-G-Hristov H-G-Hristov force-pushed the hgh/libcxx/LWG3788--jthread--operator=(jthread&&)-postconditions-are-unimplementable-under-self-assignment branch from 7a7d142 to 0806dbc Compare August 15, 2025 07:33
Copy link

github-actions bot commented Aug 15, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

…ns are unimplementable under self-assignment

Already implemented in LLVM18: 695138c

For details see: llvm#105045 (comment)

Closes llvm#105045
@H-G-Hristov H-G-Hristov force-pushed the hgh/libcxx/LWG3788--jthread--operator=(jthread&&)-postconditions-are-unimplementable-under-self-assignment branch from 0806dbc to 26474ee Compare August 15, 2025 07:37
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (w/ CI being green enough)

Copy link
Member

@huixie90 huixie90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frederick-vs-ja frederick-vs-ja merged commit 0561ede into llvm:main Aug 16, 2025
79 checks passed
@H-G-Hristov H-G-Hristov deleted the hgh/libcxx/LWG3788--jthread--operator=(jthread&&)-postconditions-are-unimplementable-under-self-assignment branch August 24, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG3788: jthread::operator=(jthread&&) postconditions are unimplementable under self-assignment

4 participants