Skip to content

Conversation

@joker-eph
Copy link
Collaborator

No description provided.

@joker-eph joker-eph added the skip-precommit-approval PR for CI feedback, not intended for review label Aug 15, 2025
@joker-eph joker-eph enabled auto-merge (squash) August 15, 2025 12:15
@llvmbot llvmbot added the mlir label Aug 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2025

@llvm/pr-subscribers-mlir

Author: Mehdi Amini (joker-eph)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/153794.diff

1 Files Affected:

  • (modified) mlir/lib/Target/Wasm/TranslateFromWasm.cpp (+2)
diff --git a/mlir/lib/Target/Wasm/TranslateFromWasm.cpp b/mlir/lib/Target/Wasm/TranslateFromWasm.cpp
index c23a2915ef18e..87f4f95745db7 100644
--- a/mlir/lib/Target/Wasm/TranslateFromWasm.cpp
+++ b/mlir/lib/Target/Wasm/TranslateFromWasm.cpp
@@ -1056,6 +1056,8 @@ class WasmBinaryParser {
   ModuleOp getModule() {
     if (isValid)
       return mOp;
+    if (mOp)
+      mOp.erase();
     return ModuleOp{};
   }
 

@joker-eph joker-eph merged commit 69453d7 into llvm:main Aug 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants