Skip to content

[X86] Explicitly widen larger than v4f16 to the legal v8f16 (NFC) #153839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

[X86] Explicitly widen larger than v4f16 to the legal v8f16 (NFC) #153839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Target/X86/X86ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2756,8 +2756,10 @@ X86TargetLowering::getPreferredVectorAction(MVT VT) const {
!Subtarget.hasBWI())
return TypeSplitVector;

// Since v8f16 is legal, widen anything over v4f16.
if (!VT.isScalableVector() && VT.getVectorNumElements() != 1 &&
!Subtarget.hasF16C() && VT.getVectorElementType() == MVT::f16)
VT.getVectorNumElements() <= 4 && !Subtarget.hasF16C() &&
VT.getVectorElementType() == MVT::f16)
return TypeSplitVector;

if (!VT.isScalableVector() && VT.getVectorNumElements() != 1 &&
Expand Down
14 changes: 14 additions & 0 deletions llvm/test/CodeGen/X86/pr152150.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
; RUN: llc < %s -mtriple=x86_64-unknown-unknown-eabi-elf | FileCheck %s

; CHECK-LABEL: conv2d
define dso_local void @conv2d() {
.preheader:
br label %0

0: ; preds = %0, %.preheader
%1 = phi [4 x <7 x half>] [ zeroinitializer, %.preheader ], [ %4, %0 ]
%2 = extractvalue [4 x <7 x half>] %1, 0
%3 = extractvalue [4 x <7 x half>] %1, 1
%4 = insertvalue [4 x <7 x half>] poison, <7 x half> poison, 3
br label %0
}