-
Notifications
You must be signed in to change notification settings - Fork 14.9k
compiler-rt: Make the tests pass on AArch64 and with page size != 4096. #153860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -965,6 +965,16 @@ def is_windows_lto_supported(): | |
else: | ||
config.available_features.add("memprof-shadow-scale-3") | ||
|
||
def target_page_size(): | ||
try: | ||
proc = subprocess.Popen(f"{emulator or ""} python3", shell=True, stdin=subprocess.PIPE, stdout=subprocess.PIPE) | ||
|
||
out, err = proc.communicate(b'import os; print(os.sysconf("SC_PAGESIZE"))') | ||
return int(out) | ||
except: | ||
return 4096 | ||
|
||
config.available_features.add(f"page-size-{target_page_size()}") | ||
|
||
if config.expensive_checks: | ||
config.available_features.add("expensive_checks") | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to the rest of the change? This doesn't work on aarch64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked closer and it's got nothing to do with the architecture, it's because my aarch64 machine has a newer gcc with this change: gcc-mirror/gcc@361d230
I'll split this into a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#153873