Skip to content

[Clang][NFC] Avoid repeating copy of std::string in lambda implementation #153863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Clang][NFC] Avoid repeating copy of std::string in lambda implementation #153863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c9039
[Clang][NFC] Avoid repeating copy of std::string in lambda implementa…
shafik Aug 15, 2025
2eab0c5
apply clang-format
shafik Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,9 @@ class FullDependencyConsumer : public DependencyConsumer {
std::optional<P1689ModuleInfo> Provided,
std::vector<P1689ModuleInfo> Requires) override {
ModuleName = Provided ? Provided->ModuleName : "";
llvm::transform(Requires, std::back_inserter(NamedModuleDeps),
[](const auto &Module) { return Module.ModuleName; });
llvm::transform(
Requires, std::back_inserter(NamedModuleDeps),
[](const auto &Module) -> const auto & { return Module.ModuleName; });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, you're doing a copy either way: you're inserting a string into an std::vector<std::string>. At best this saves a move constructor call.

}

TranslationUnitDeps takeTranslationUnitDeps();
Expand Down